🌱 Introduce a new go.mod for test/ #2532

fabriziopandini · 2023-12-06T14:16:31Z

What this PR does / why we need it:
This PR introduces a go.mod file for the test/ folder, thus removing kind, docker and other dependencies from the main go.mod file, ultimately reducing the surface for CVEs/vulnerabilities for the CAPV manager

fabriziopandini · 2023-12-06T16:31:08Z

/test pull-cluster-api-provider-vsphere-test-main

Makefile

codecov · 2023-12-06T17:45:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6c02a9) 63.46% compared to head (8c61199) 64.14%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   63.46%   64.14%   +0.68%     
==========================================
  Files         119      118       -1     
  Lines        8592     8535      -57     
==========================================
+ Hits         5453     5475      +22     
+ Misses       2722     2642      -80     
- Partials      417      418       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrischdi

Just some nits, rest looks good!

chrischdi · 2023-12-06T17:49:19Z

internal/test/helpers/mod.go

@@ -41,6 +43,7 @@ func NewMod(path string) (Mod, error) {
 	}, nil
 }

+// FindDependencyVersion return the version of a go.mod dependency.
 func (m Mod) FindDependencyVersion(dependency string) (string, error) {


Do we even use this?

Found nothing, maybe in your vcsim branch?

I just moved stuff around, we can clean up as a follow up

internal/test/helpers/vcsim/simulator.go

chrischdi

Just some nits, rest looks good!

sbueringer · 2023-12-08T13:37:19Z

Would be great if we can merge #2527 first. I just want to avoid rebasing #2527

chrischdi · 2023-12-12T15:41:05Z

#2527 is now merged, this one requires a rebase :-)

test/go.mod

test/e2e/e2e_suite_test.go

test/framework/framework.go

test/go.mod

go.mod

Makefile

sbueringer · 2023-12-14T13:16:22Z

Makefile

@@ -280,6 +281,7 @@ generate-go-deepcopy: $(CONTROLLER_GEN) ## Generate deepcopy go code for core
 .PHONY: generate-modules
 generate-modules: ## Run go mod tidy to ensure modules are up to date


It's highly likely that we have to introduce a dependabot action (see pr-dependabot.yaml from core CAPI).

But I'm fine waiting for the first time a dependabot PR fails with modules being out of sync and then only adding it if actually needed (it's very likely as we needed it in core CAPI & CR as well as soon as we had multiple modules referencing each other)

sbueringer · 2023-12-14T13:17:27Z

Thx! I like that we get rid of a few annoying dependencies in the top-level go.mod file

.github/workflows/pr-golangci-lint.yaml

sbueringer · 2023-12-15T14:58:20Z

Last two smaller findings

(#2532 (comment) #2532 (comment))

fabriziopandini · 2023-12-20T11:23:26Z

/test pull-cluster-api-provider-vsphere-test-main

sbueringer · 2023-12-20T12:27:34Z

/lgtm
/approve

/hold
for squash

k8s-ci-robot · 2023-12-20T12:27:41Z

LGTM label has been added.

Git tree hash: de56d6e21539174bd90137fd24a0719adb97b213

k8s-ci-robot · 2023-12-20T12:27:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2023-12-20T12:40:08Z

Thank you!

/hold cancel

k8s-ci-robot · 2023-12-20T12:40:09Z

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	`8c61199`	link	false	`/test pull-cluster-api-provider-vsphere-apidiff-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2023

k8s-ci-robot requested review from chrischdi and srm09 December 6, 2023 14:16

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 6, 2023

sbueringer reviewed Dec 6, 2023

View reviewed changes

Makefile Show resolved Hide resolved

chrischdi reviewed Dec 6, 2023

View reviewed changes

chrischdi mentioned this pull request Dec 7, 2023

🌱 Add clusterctl upgrade test #2517

Merged

3 tasks

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023

chrischdi reviewed Dec 12, 2023

View reviewed changes

test/go.mod Outdated Show resolved Hide resolved

chrischdi reviewed Dec 13, 2023

View reviewed changes

test/go.mod Outdated Show resolved Hide resolved

fabriziopandini force-pushed the split-go-modules branch from 8433e68 to 3655049 Compare December 13, 2023 17:03

sbueringer reviewed Dec 14, 2023

View reviewed changes

fabriziopandini force-pushed the split-go-modules branch from 3655049 to c9dd3ff Compare December 15, 2023 13:37

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2023

sbueringer reviewed Dec 15, 2023

View reviewed changes

.github/workflows/pr-golangci-lint.yaml Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2023

fabriziopandini force-pushed the split-go-modules branch from c9dd3ff to 0575040 Compare December 20, 2023 11:07

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023

k8s-ci-robot assigned sbueringer Dec 20, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023

sbueringer mentioned this pull request Dec 20, 2023

🌱 Bump vmoperator to v1.8.5 & vmware dependencies #2562

Merged

introduce a new go.mod for test/

8c61199

fabriziopandini force-pushed the split-go-modules branch from 0575040 to 8c61199 Compare December 20, 2023 12:33

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023

k8s-ci-robot merged commit c8371a6 into kubernetes-sigs:main Dec 20, 2023
15 of 16 checks passed

k8s-ci-robot added this to the v1.9 milestone Dec 20, 2023

chrischdi mentioned this pull request Dec 27, 2023

🌱 Dependabot: add github action to fix modules on PRs and add test to configuration #2573

Merged

fabriziopandini deleted the split-go-modules branch January 8, 2024 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 Introduce a new go.mod for test/ #2532

🌱 Introduce a new go.mod for test/ #2532

fabriziopandini commented Dec 6, 2023

fabriziopandini commented Dec 6, 2023

codecov bot commented Dec 6, 2023 •

edited

Loading

chrischdi left a comment

chrischdi Dec 6, 2023

fabriziopandini Dec 20, 2023

chrischdi left a comment

sbueringer commented Dec 8, 2023

chrischdi commented Dec 12, 2023

sbueringer Dec 14, 2023

sbueringer commented Dec 14, 2023

sbueringer commented Dec 15, 2023 •

edited

Loading

fabriziopandini commented Dec 20, 2023

sbueringer commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

sbueringer commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

		@@ -280,6 +281,7 @@ generate-go-deepcopy: $(CONTROLLER_GEN) ## Generate deepcopy go code for core
		.PHONY: generate-modules
		generate-modules: ## Run go mod tidy to ensure modules are up to date

🌱 Introduce a new go.mod for test/ #2532

🌱 Introduce a new go.mod for test/ #2532

Conversation

fabriziopandini commented Dec 6, 2023

fabriziopandini commented Dec 6, 2023

codecov bot commented Dec 6, 2023 • edited Loading

Codecov Report

chrischdi left a comment

Choose a reason for hiding this comment

chrischdi Dec 6, 2023

Choose a reason for hiding this comment

fabriziopandini Dec 20, 2023

Choose a reason for hiding this comment

chrischdi left a comment

Choose a reason for hiding this comment

sbueringer commented Dec 8, 2023

chrischdi commented Dec 12, 2023

sbueringer Dec 14, 2023

Choose a reason for hiding this comment

sbueringer commented Dec 14, 2023

sbueringer commented Dec 15, 2023 • edited Loading

fabriziopandini commented Dec 20, 2023

sbueringer commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

sbueringer commented Dec 20, 2023

k8s-ci-robot commented Dec 20, 2023

codecov bot commented Dec 6, 2023 •

edited

Loading

sbueringer commented Dec 15, 2023 •

edited

Loading