🌱 Bump vmoperator to v1.8.5 & vmware dependencies #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
commented
Dec 20, 2023
| github.com/vmware-tanzu/net-operator-api v0.0.0-20231019160108-42131d6e8360 | ||
| github.com/vmware-tanzu/vm-operator/api v1.8.5 | ||
| github.com/vmware-tanzu/vm-operator/external/ncp v0.0.0-20231214185006-5477585eebfd | ||
| github.com/vmware-tanzu/vm-operator/external/tanzu-topology v0.0.0-20231214185006-5477585eebfd | ||
| github.com/vmware/govmomi v0.34.0 |
There was a problem hiding this comment.
Checked:
- github.com/vmware-tanzu/net-operator-api
- github.com/vmware-tanzu/vm-operator/external/ncp
- github.com/vmware-tanzu/vm-operator/external/tanzu-topology
Each of these only contain one CRD that we use. The CRDs either didn't change or we are not reading any fields (AvailabilityZone)
Based on Sagar's guidance it should be fine to bump vm-operator to v1.8.5
sbueringer
changed the title
|
/hold Let's merge the test module thing first |
k8s-ci-robot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2562 +/- ##
==========================================
- Coverage 64.18% 63.87% -0.31%
==========================================
Files 118 118
Lines 8535 8535
==========================================
- Hits 5478 5452 -26
- Misses 2638 2657 +19
- Partials 419 426 +7 ☔ View full report in Codecov by Sentry. |
sbueringer
force-pushed
the
pr-bump-vmoperator
branch
from
754d219
to
d00361a
Compare
k8s-ci-robot
added
size/XXL
sbueringer
force-pushed
the
pr-bump-vmoperator
branch
from
d00361a
to
e9fdf28
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f0b33b4045efa43e6e86ee6661325d6d89828c24
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #