Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Add exp/ package with MachinePool #2512

Merged
merged 1 commit into from
Mar 4, 2020
Merged

⚠️ Add exp/ package with MachinePool #2512

merged 1 commit into from
Mar 4, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Mar 3, 2020

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:
⚠️ Lots of changes ahead, proceed with caution 😄

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 3, 2020
@vincepri
Copy link
Member Author

vincepri commented Mar 3, 2020

/assign @ncdc @juan-lee

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@vincepri
Copy link
Member Author

vincepri commented Mar 3, 2020 •
edited
Loading

@chuckha It seems like the test framework is pointing to a hash of CAPI instead of local import, which is causing CI to fail, I can probably update it in another PR. What was the reasoning behind not using local import for CAPI when using the test framework?

detiber
detiber reviewed Mar 3, 2020
View reviewed changes
bootstrap/kubeadm/controllers/kubeadmconfig_controller.go Outdated Show resolved Hide resolved
bootstrap/util/configowner.go Outdated Show resolved Hide resolved
cmd/clusterctl/pkg/client/cluster/mover_test.go Outdated Show resolved Hide resolved
config/crd/bases/exp.cluster.x-k8s.io_machinepools.yaml Show resolved Hide resolved
exp/api/v1alpha3/groupversion_info.go Show resolved Hide resolved
exp/hack/boilerplate.go.txt Show resolved Hide resolved
test/framework/control_plane.go Show resolved Hide resolved
test/framework/convenience.go Show resolved Hide resolved
test/framework/dump_resources.go Show resolved Hide resolved
test/infrastructure/docker/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2020
detiber
detiber reviewed Mar 3, 2020
View reviewed changes
go.sum Show resolved Hide resolved
detiber
detiber reviewed Mar 3, 2020
View reviewed changes
main.go Show resolved Hide resolved
@vincepri vincepri changed the title ⚠️ Add exp/ package with MachinePool wip: ⚠️ Add exp/ package with MachinePool Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2020
@vincepri
Copy link
Member Author

vincepri commented Mar 3, 2020

/test pull-cluster-api-capd-e2e

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2020
@vincepri vincepri added this to the v0.3.0-rc.3 milestone Mar 4, 2020
@vincepri
⚠️ Add exp/ package with MachinePool
12e9625 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
detiber
detiber reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@vincepri vincepri changed the title wip: ⚠️ Add exp/ package with MachinePool ⚠️ Add exp/ package with MachinePool Mar 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4c6e9d9 into kubernetes-sigs:master Mar 4, 2020
@vincepri vincepri mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@detiber detiber detiber left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@chuckha chuckha Awaiting requested review from chuckha

Assignees

@ncdc ncdc

@detiber detiber

@juan-lee juan-lee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.3
Development

Successfully merging this pull request may close these issues.
5 participants
@vincepri @k8s-ci-robot @ncdc @detiber @juan-lee