Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ensure every directory with a module is included in the top level makefile's modules target #2561

Closed
wants to merge 1 commit into from

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Mar 6, 2020

Signed-off-by: SataQiu 1527062125@qq.com

What this PR does / why we need it:
Ensure every directory with a module is included in the top level makefile's modules target.
Make test/framework as a module to resolve :

shida@machine:~/Documents/Develop/work/src/sigs.k8s.io/cluster-api/cmd/clusterctl/test/e2e [master] $ go mod tidy
go: sigs.k8s.io/cluster-api/test/framework@v0.0.0-20200125173702-54f26d7fd2b5: parsing ../../../../test/framework/go.mod: open /Users/shida/Documents/Develop/work/src/sigs.k8s.io/cluster-api/test/framework/go.mod: no such file or directory

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

/cc @chuckha

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SataQiu
To complete the pull request process, please assign neolit123
You can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 6, 2020
@@ -0,0 +1,19 @@
module sigs.k8s.io/cluster-api/test/framework
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually removed in #2512 and it's going to ship with CAPI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out @vincepri !
But is there a good way to solve this problem? 😕

ensure modules: /home/prow/go/src/sigs.k8s.io/cluster-api/cmd/clusterctl/test/e2e
go: sigs.k8s.io/cluster-api/test/framework@v0.0.0-20200125173702-54f26d7fd2b5: parsing ../../../../test/framework/go.mod: open /home/prow/go/src/sigs.k8s.io/cluster-api/test/framework/go.mod: no such file or directory 

…efile's modules target

Signed-off-by: SataQiu <1527062125@qq.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

@SataQiu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-verify 6b866d3 link /test pull-cluster-api-verify
pull-cluster-api-capd-e2e 6b866d3 link /test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

It seems this PR is replicating a change already implemented in https://github.com/kubernetes-sigs/cluster-api/pull/2552/files

@SataQiu
Copy link
Member Author

SataQiu commented Mar 6, 2020

Duplicate with #2552
/close

@k8s-ci-robot
Copy link
Contributor

@SataQiu: Closed this PR.

In response to this:

Duplicate with #2552
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clusterctl] add clusterctl's e2e test module to make module target
4 participants