-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Ensure every directory with a module is included in the top level makefile's modules target #2561
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SataQiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/framework/go.mod
Outdated
@@ -0,0 +1,19 @@ | |||
module sigs.k8s.io/cluster-api/test/framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually removed in #2512 and it's going to ship with CAPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out @vincepri !
But is there a good way to solve this problem? 😕
ensure modules: /home/prow/go/src/sigs.k8s.io/cluster-api/cmd/clusterctl/test/e2e
go: sigs.k8s.io/cluster-api/test/framework@v0.0.0-20200125173702-54f26d7fd2b5: parsing ../../../../test/framework/go.mod: open /home/prow/go/src/sigs.k8s.io/cluster-api/test/framework/go.mod: no such file or directory
…efile's modules target Signed-off-by: SataQiu <1527062125@qq.com>
ae353aa
to
6b866d3
Compare
@SataQiu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It seems this PR is replicating a change already implemented in https://github.com/kubernetes-sigs/cluster-api/pull/2552/files |
Duplicate with #2552 |
@SataQiu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: SataQiu 1527062125@qq.com
What this PR does / why we need it:
Ensure every directory with a module is included in the top level makefile's modules target.
Make test/framework as a module to resolve :
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2457
/cc @chuckha