nfd-master: drop stale variables #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
cncf-cla: yes
|
/assign @ArangoGutierrez |
k8s-ci-robot
added
the
size/M
Remove some stale variables that were leftover from the recent removal of nfd version annotations.
marquiz
force-pushed
the
devel/nfd-master-refactor
branch
from
ea603a6
to
678d7e8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
==========================================
- Coverage 30.55% 30.49% -0.07%
==========================================
Files 58 58
Lines 7527 7520 -7
==========================================
- Hits 2300 2293 -7
Misses 4978 4978
Partials 249 249
|
This was referenced Nov 23, 2023
go test -covermode=atomic -coverprofile=coverage.out ./cmd/... ./pkg/... ./source/...
ok sigs.k8s.io/node-feature-discovery/cmd/nfd-gc 0.608s coverage: 35.7% of statements
? sigs.k8s.io/node-feature-discovery/cmd/nfd-master [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/apihelper [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/clientset/versioned [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/clientset/versioned/fake [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/clientset/versioned/scheme [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/clientset/versioned/typed/nfd/v1alpha1 [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/clientset/versioned/typed/nfd/v1alpha1/fake [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/informers/externalversions [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/informers/externalversions/internalinterfaces [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/informers/externalversions/nfd [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/labeler [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/listers/nfd/v1alpha1 [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/generated/informers/externalversions/nfd/v1alpha1 [no test files]
ok sigs.k8s.io/node-feature-discovery/cmd/nfd-topology-updater 0.561s coverage: 51.1% of statements
ok sigs.k8s.io/node-feature-discovery/cmd/nfd-worker 0.927s coverage: 50.0% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/apis/nfd/v1alpha1 0.649s coverage: 21.8% of statements
? sigs.k8s.io/node-feature-discovery/pkg/nfd-topology-updater/kubeletnotifier [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/podres [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/podres/mocks [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/utils/hostpath [no test files]
? sigs.k8s.io/node-feature-discovery/pkg/version [no test files]
? sigs.k8s.io/node-feature-discovery/source/custom [no test files]
? sigs.k8s.io/node-feature-discovery/source/fake [no test files]
ok sigs.k8s.io/node-feature-discovery/pkg/nfd-gc 4.473s coverage: 41.8% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/nfd-master 13.820s coverage: 52.7% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/nfd-topology-updater 1.175s coverage: 4.3% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/nfd-worker 4.386s coverage: 69.4% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/resourcemonitor 1.765s coverage: 75.7% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/topologypolicy 1.226s coverage: 100.0% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/utils 1.429s coverage: 18.0% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/utils/klog 1.349s coverage: 17.4% of statements
ok sigs.k8s.io/node-feature-discovery/pkg/utils/kubeconf 0.738s coverage: 30.6% of statements
ok sigs.k8s.io/node-feature-discovery/source 0.505s coverage: 22.4% of statements
ok sigs.k8s.io/node-feature-discovery/source/cpu 0.289s coverage: 19.0% of statements
ok sigs.k8s.io/node-feature-discovery/source/kernel 0.386s coverage: 9.1% of statements
ok sigs.k8s.io/node-feature-discovery/source/local 0.378s coverage: 48.6% of statements
ok sigs.k8s.io/node-feature-discovery/source/memory 0.352s coverage: 21.6% of statements
ok sigs.k8s.io/node-feature-discovery/source/network 0.463s coverage: 18.8% of statements
ok sigs.k8s.io/node-feature-discovery/source/pci 0.418s coverage: 24.4% of statements
ok sigs.k8s.io/node-feature-discovery/source/storage 0.521s coverage: 25.0% of statements
ok sigs.k8s.io/node-feature-discovery/source/system 0.494s coverage: 22.2% of statements
ok sigs.k8s.io/node-feature-discovery/source/usb 0.566s coverage: 23.3% of statementsgo test -v ./test/e2e/ -args -nfd.repo=ghcr.io/arangogutierrez/node-feature-discovery -nfd.tag=v0.15.0-devel-128-g678d7e89-dirty \
-kubeconfig=/Users/eduardoa/.kube/config \
-nfd.e2e-config= \
-nfd.pull-if-not-present=false \
-ginkgo.focus="\[kubernetes-sigs\] NFD master and worker" \
-test.timeout=1h \
Nov 24 11:01:20.821: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
=== RUN TestE2E
I1124 11:01:20.821963 12503 e2e.go:117] Starting e2e run "d1a89f73-aabc-401d-81cf-14a1375b7ad8" on Ginkgo node 1
Running Suite: Kubernetes e2e suite - /Users/eduardoa/src/github/k8s-sigs/node-feature-discovery/test/e2e
=========================================================================================================
Random Seed: 1700820080 - will randomize all specs
Will run 16 of 299 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•S•SS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•S••••S•SSSSSSSSSSSSSSSSSSS
Ran 9 of 299 Specs in 117.792 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 290 Skipped |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3603ccedc78eb7a8f9365cc1084c0cef0d84a455
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some stale variables that were leftover from the recent removal of nfd version annotations.