nfd-master: predictable handling of unprefixed names #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some stale variables that were leftover from the recent removal of nfd version annotations.
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Depends on #1470 |
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
devel/default-ns-fix
branch
from
f1dd050
to
9200ca3
Compare
Make the handling of unprefixed names (of labels, annotations and extended resources) well-defined and predictable. Previously the resulting output was not predictable in case the same name was coming in both the unprefixed and prefixed form, say unprefixed "foo=bar" coming from one source (be it nfd-worker or NodeFeature(Rule)) and "feature.node.kubernetes.io/foo=baz" from a NodeFeature(Rule). Previously the output value was randomly either "bar" or "baz". This patch adds prefixes to all names early in the processing "pipeline", preventing random name clashes later on.
marquiz
force-pushed
the
devel/default-ns-fix
branch
from
9200ca3
to
dc5af8b
Compare
ArangoGutierrez
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
go test -v ./test/e2e/ -args -nfd.repo=ghcr.io/arangogutierrez/node-feature-discovery -nfd.tag=v0.15.0-devel-129-gdc5af8be-dirty \
-kubeconfig=/Users/eduardoa/.kube/config \
-nfd.e2e-config= \
-nfd.pull-if-not-present=false \
-ginkgo.focus="\[kubernetes-sigs\] NFD master and worker" \
-test.timeout=1h \
Nov 24 11:08:50.847: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
=== RUN TestE2E
I1124 11:08:50.847912 13265 e2e.go:117] Starting e2e run "fd76fdfb-fdcf-42c2-89fd-ddef8ed78fea" on Ginkgo node 1
Running Suite: Kubernetes e2e suite - /Users/eduardoa/src/github/k8s-sigs/node-feature-discovery/test/e2e
=========================================================================================================
Random Seed: 1700820530 - will randomize all specs
Will run 16 of 299 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•S•SS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•S••••S•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 9 of 299 Specs in 119.999 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 290 Skipped/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 08602e8f2d49e3955481c6f65e69e24550b89e65
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
do-not-merge/hold
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 30.55% 30.51% -0.04%
==========================================
Files 58 58
Lines 7527 7530 +3
==========================================
- Hits 2300 2298 -2
- Misses 4978 4982 +4
- Partials 249 250 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the handling of unprefixed names (of labels, annotations and
extended resources) well-defined and predictable. Previously the
resulting output was not predictable in case the same name was coming in
both the unprefixed and prefixed form, say unprefixed
foo=barcoming fromone source (be it nfd-worker or NodeFeature(Rule)) and
feature.node.kubernetes.io/foo=bazfrom a NodeFeature(Rule).Previously the output value was randomly either
barorbaz.This patch adds prefixes to all names early in the processing
"pipeline", preventing random name clashes later on.