Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology updater: add e2e tests #528

Merged
merged 3 commits into from
Aug 11, 2022
Merged

topology updater: add e2e tests #528

merged 3 commits into from
Aug 11, 2022

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented May 18, 2021 •
edited
Loading

Builds on top of #525 and add e2e tests for the new component.
Some refactoring was performed along the way to make room for the new tests; no intended changes in the behaviour of the existing tests.

Design Document: here
Issue: #333
Documentation: #526

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @fromanirh!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @fromanirh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2021
@ffromani ffromani mentioned this pull request May 18, 2021
Closed
@ffromani ffromani force-pushed the topology-updater-e2e-tests branch from 547a029 to 0be8192 Compare May 18, 2021 09:30
@ffromani
Copy link
Contributor Author

reviewers please note the first 4 commits (up to Expose Topology manager scope, included) are part of #525 , and are included here for PR consistency sake and to make CI pass.

@swatisehgal
Copy link
Contributor

swatisehgal commented May 18, 2021 •
edited
Loading

/cc @marquiz @ArangoGutierrez

In case you would like to review the E2E tests corresponding to #525.

@Tal-or Tal-or mentioned this pull request May 18, 2021
Closed
@Tal-or Tal-or mentioned this pull request Jun 16, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2021
@swatisehgal swatisehgal mentioned this pull request Jul 13, 2021
Merged
@ffromani ffromani changed the title Topology updater: add e2e tests WIP: Topology updater: add e2e tests Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@ffromani ffromani force-pushed the topology-updater-e2e-tests branch 2 times, most recently from 602565e to b3d2819 Compare August 4, 2021 16:40
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@marquiz
Copy link
Contributor

marquiz commented Sep 16, 2021

Rebase and drop the vendor directory

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2021
marquiz
marquiz requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the vendor/ dir

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2021
@ffromani ffromani changed the title WIP: Topology updater: add e2e tests topology updater: add e2e tests Sep 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022
@ffromani ffromani force-pushed the topology-updater-e2e-tests branch 2 times, most recently from d9fa944 to a4252aa Compare August 9, 2022 10:08
@ffromani ffromani changed the title WIP: topology updater: add e2e tests topology updater: add e2e tests Aug 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Aug 9, 2022

the PR is now reivewable again, but depends on #854

marquiz
marquiz reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @fromanirh, I was now actually able to run the e2e-tests successfully in our test cluster 🥳

I left just a few comments but after those I think we're good to go with this

test/e2e/utils/config.go Show resolved Hide resolved
test/e2e/topology_updater.go Outdated Show resolved Hide resolved
test/e2e/utils/pod.go Show resolved Hide resolved
test/e2e/utils/noderesourcetopology.go Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2022

We actually need to update our e2e-test-config in k8s test-infra before merging this (I'm on it)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@ffromani
test: e2e: configurable pull policy
622adf3 
In some cases (CI) it is useful to run NFD e2e tests using
ephemeral clusters. To save time and bandwidth, it is also useful
to prime the ephemeral cluster with the images under test.

In these circumstances there is no risk of running a stale image,
and having a `Always` PullPolicy hardcoded actually makes
the whole exercise null.

So we add a new option, disabled by default, to make the e2e
manifest use the `IfNotPresent` pull policy, to effectively
cover this use case.

Signed-off-by: Francesco Romani <fromani@redhat.com>
marquiz
marquiz reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there. Just a few more notes.

test/e2e/utils/pod.go Outdated Show resolved Hide resolved
test/e2e/utils/pod.go Outdated Show resolved Hide resolved
test/e2e/utils/config.go Show resolved Hide resolved
@marquiz marquiz mentioned this pull request Aug 10, 2022
Merged
@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2022

We also need kubernetes/test-infra#27106 to get merged before merging this one.

ffromani and others added 2 commits August 11, 2022 08:53
@ffromani @swatisehgal
e2e: add basic topology updater test
7d37f72 
Co-authored-by: Swati Sehgal <swsehgal@redhat.com>
Co-authored-by: Francesco Romani <fromani@redhat.com>
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@ffromani
test: utils: borrow fixed GetKubeletConfig from k/k
d70f8c6 
We need this fix kubernetes/kubernetes#110875
to have reliable tests, but up until we can bump the k/k deps to 1.25+,
we can't consume it.

So borrow it from k/k repo for the time being.

Signed-off-by: Francesco Romani <fromani@redhat.com>
marquiz
marquiz approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great persistence @fromanirh on this one 😊 I think this is good to go now 🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@marquiz
Copy link
Contributor

marquiz commented Aug 11, 2022

...just need to get that test-infra pr merged in order to unhold this

@ffromani
Copy link
Contributor Author

Thanks for the reviews @marquiz !

@marquiz
Copy link
Contributor

marquiz commented Aug 11, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 65bdcaa into kubernetes-sigs:master Aug 11, 2022
@ffromani ffromani deleted the topology-updater-e2e-tests branch August 11, 2022 12:30
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ffromani @k8s-ci-robot @swatisehgal @marquiz @ArangoGutierrez @k8s-triage-robot