Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move e2e-test helpers to a separate package #854

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Move e2e-test helpers to a separate package #854

merged 1 commit into from
Aug 9, 2022

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Aug 8, 2022 •
edited
Loading

This cleanup/refactoring will facilitate the addition of the nfd-topology-updater tests (#528)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @fromanirh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 8, 2022
@ffromani ffromani mentioned this pull request Aug 8, 2022
Merged
@ffromani ffromani changed the title Move helpers method to the separate package WIP: Move helpers method to the separate package Aug 8, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Aug 8, 2022

WIP: I think I addressed all the relevant commits, but I'd like to run clean and CI and want to run tests on my side before to mark it reviewable

@ffromani ffromani force-pushed the topology-updater-e2e-tests-utils branch from 9a4368c to 43990cc Compare August 8, 2022 12:13
@ffromani
Copy link
Contributor Author

ffromani commented Aug 8, 2022

@marquiz could I please have ok-to-test here so I can run the final checks before to mark this reviewable?

@ffromani
Copy link
Contributor Author

ffromani commented Aug 8, 2022 •
edited
Loading

seems to work fine, albeit on a 1.22 kind cluster. OTOH nothing here requires kube >= 1.23, so removing the WIP

@ffromani ffromani changed the title WIP: Move helpers method to the separate package Move helpers method to the separate package Aug 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@marquiz
Copy link
Contributor

marquiz commented Aug 9, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2022
@ffromani ffromani force-pushed the topology-updater-e2e-tests-utils branch from 43990cc to c5eacfa Compare August 9, 2022 07:40
marquiz
marquiz requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fromanirh! This is a good improvement on the code base and it makes sense to review this in a separate PR. I had a few minor notes but after these are fixed lgtm.

test/e2e/utils/config.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
test/e2e/utils/pod.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery.go Outdated Show resolved Hide resolved
@ffromani
Move helpers method to the separate package
e169edc 
Co-Authored-By Francesco Romani <fromani@redhat.com>
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@ffromani ffromani force-pushed the topology-updater-e2e-tests-utils branch from c5eacfa to e169edc Compare August 9, 2022 11:48
marquiz
marquiz approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ggod to me now 👍 If anything shows up let's fix it separately later 😄
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@marquiz
Copy link
Contributor

marquiz commented Aug 9, 2022

/retitle Move e2e-test helpers method to the separate package

@k8s-ci-robot k8s-ci-robot changed the title Move helpers method to the separate package Move e2e-test helpers method to the separate package Aug 9, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Aug 9, 2022

Looks ggod to me now +1 If anything shows up let's fix it separately later smile /lgtm

sure thing! thanks for the quick reviews!

@marquiz
Copy link
Contributor

marquiz commented Aug 9, 2022

/retitle Move e2e-test helpers to a separate package

@k8s-ci-robot k8s-ci-robot changed the title Move e2e-test helpers method to the separate package Move e2e-test helpers to a separate package Aug 9, 2022
@marquiz
Copy link
Contributor

marquiz commented Aug 9, 2022

/test pull-node-feature-discovery-build-image-cross

@k8s-ci-robot k8s-ci-robot merged commit d3446b6 into kubernetes-sigs:master Aug 9, 2022
@ffromani ffromani deleted the topology-updater-e2e-tests-utils branch August 9, 2022 13:20
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@kad kad Awaiting requested review from kad

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffromani @k8s-ci-robot @marquiz