Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfile: update builder image to golang v1.18 #836

Merged
merged 1 commit into from
Aug 8, 2022
Merged

dockerfile: update builder image to golang v1.18 #836

merged 1 commit into from
Aug 8, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jun 29, 2022 •
edited
Loading

Switch over to the "non-point-release" version of the image. Now we
always use the latest patch version of golang with latest security
fixes, for example, without the need to manually bump the version after
every point release.

This patch also makes the builder image configurable through a Makefile
variable.

For reproducible builds we should used fixed point-release versions in
release-brances.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jun 29, 2022

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
e0ne
e0ne reviewed Jul 7, 2022
View reviewed changes
Dockerfile
@@ -2,7 +2,7 @@ ARG BASE_IMAGE_FULL
ARG BASE_IMAGE_MINIMAL

# Build node feature discovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to specify just 1.18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e0ne for the suggestion. The reason we've been using "fixed" golang versions has been reproducibility but I realized it doesn't make much sense in master. Changed as you suggested.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2022

/retitle dockerfile: update builder image to golang v1.18

@k8s-ci-robot k8s-ci-robot changed the title dockerfile: update builder image to golang v1.18.3 dockerfile: update builder image to golang v1.18 Jul 8, 2022
@marquiz
dockerfile: update builder image to golang v1.18
8d56634 
Switch over to the "non-point-release" version of the image. Now we
always use the latest patch version of golang with latest security
fixes, for example, without the need to manually bump the version after
every point release.

This patch also makes the builder image configurable through a Makefile
variable.

For reproducible builds we should used fixed point-release versions in
release-brances.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2022
@marquiz marquiz mentioned this pull request Jul 8, 2022
Merged
e0ne
e0ne approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my commments

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: e0ne, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Aug 8, 2022

ping @ArangoGutierrez

@marquiz
Copy link
Contributor Author

marquiz commented Aug 8, 2022

/cc zvonkok

@mythi
Copy link
Contributor

mythi commented Aug 8, 2022

Time for 1.19 while we're at it?

@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit f0ce6ac into kubernetes-sigs:master Aug 8, 2022
@marquiz marquiz deleted the devel/golang-update branch August 9, 2022 05:11
@marquiz
Copy link
Contributor Author

marquiz commented Aug 9, 2022

Time for 1.19 while we're at it?

Let's do that separately.

@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
@ArangoGutierrez ArangoGutierrez mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marquiz @k8s-ci-robot @mythi @ArangoGutierrez @e0ne