Improvements to scripts/prepare-release.sh #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Depends on #836 /hold |
k8s-ci-robot
added
approved
Implement a new command line option "-b" to prevent the script from creating release assets (Helm chart).
Make the GPG signing an optional argument. It doesn't make much sense to require that when no assets are being generated (i.e. when "-b" is used).
Make it mandatory to specify a golang version with "-g" when running the script (and patching repo content). The given version will be patched into the Makefile to fix the version used in the release build - it is meant to use a exact point release (like 1.18.3) to get reproducible builds.
marquiz
force-pushed
the
devel/prepare-release-golang-version
branch
from
917556e
to
989565d
Compare
|
#836 was merged /unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the release preparation script. The main motivation is to make the golang version fixed for release builds.
-bto not generate assetsImplement a new command line option
-bto prevent the script fromcreating release assets (Helm chart).
-kto specify the signing keyMake the GPG signing an optional argument. It doesn't make much sense to
require that when no assets are being generated (i.e. when
-bisused).
Make it mandatory to specify a golang version with
-gwhen running thescript (and patching repo content). The given version will be patched
into the Makefile to fix the version used in the release build - it is
meant to use a exact point release (like 1.18.3) to get reproducible
builds.
Depends on #836