Update CPU flags for ARM, POWER, and Z #919
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yselkowitz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
| @@ -78,6 +87,15 @@ var flagNames_arm64 = map[uint64]string{ | |||
| CPU_ARM64_FEATURE_ASIMDDP: "ASIMDDP", | |||
| CPU_ARM64_FEATURE_SHA512: "SHA512", | |||
| CPU_ARM64_FEATURE_SVE: "SVE", | |||
| CPU_ARM64_FEATURE_ASIMDFHM: "ASIMDFHM", | |||
| CPU_ARM64_FEATURE_DIT: "DIT", | |||
There was a problem hiding this comment.
@yselkowitz Where is the list of arm cpu features coming from? I see this in go, but I don't see all of the flags you're mentioning here.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think for future reference, https://github.com/torvalds/linux/blob/master/arch/s390/include/asm/elf.h is a better source for cpu flags for s390x. Though in the end glibc is probably getting it from there anyway.
There was a problem hiding this comment.
Not to pollute the code base.... however. would a comment pointing back to the source be helpful in future maintenance ?
k8s-ci-robot
added
size/L
|
Thanks @yselkowitz for the update! Looks good to me but I'd like to get thumbs-up from some non-x86 specialist (@mkumatag?) 😊 |
k8s-ci-robot
added
ok-to-test
|
s390x: lgtm Thank you @yselkowitz |
|
ping @pmundt arm |
|
ping @lubinszARM |
| @@ -78,6 +87,15 @@ var flagNames_arm64 = map[uint64]string{ | |||
| CPU_ARM64_FEATURE_ASIMDDP: "ASIMDDP", | |||
| CPU_ARM64_FEATURE_SHA512: "SHA512", | |||
| CPU_ARM64_FEATURE_SVE: "SVE", | |||
| CPU_ARM64_FEATURE_ASIMDFHM: "ASIMDFHM", | |||
| CPU_ARM64_FEATURE_DIT: "DIT", | |||
There was a problem hiding this comment.
Not to pollute the code base.... however. would a comment pointing back to the source be helpful in future maintenance ?
k8s-ci-robot
added
the
lgtm
@yselkowitz this would make sense to me. WDYT |
k8s-ci-robot
removed
the
lgtm
|
Rebased and added comments with links to the kernel/glibc sources. |
There was a problem hiding this comment.
Nice work @yselkowitz. Looks ready from my pov. I'll let somebody else to lgtm 😊
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, prb112, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @mkumatag |
|
arm: lgtm Good job. @yselkowitz |
|
Thanks for all the reviews |
k8s-ci-robot
added
the
lgtm
Backport of kubernetes-sigs/node-feature-discovery#919 including the following upstream commits: cpu: update ARM CPU flags through v8.3 cpu: update ARM CPU flags through v9.2 cpu: add POWER10 CPU flags cpu: update S390 CPU flags cpu: document canonical sources of supported CPU flags
Backport of kubernetes-sigs/node-feature-discovery#919 including the following upstream commits: cpu: update ARM CPU flags through v8.3 cpu: update ARM CPU flags through v9.2 cpu: add POWER10 CPU flags cpu: update S390 CPU flags cpu: document canonical sources of supported CPU flags
These updates are based on kernel 5.19.4 and glibc 2.36.
Related: #914
Closes: #913