-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: fix 32-bit ARMv8 CPU flags #927
Conversation
@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: lubinszARM. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @yselkowitz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/ok-to-test
@yselkowitz #914 was merged so this PR should be rebased |
32-bit ARMv8 Crypto Extensions are exposed through AT_HWCAP2. IDIV is not an individual flag, but indicates both IDIVA and IDIVT are present.
@marquiz rebased, CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yselkowitz. Good to go from my pov
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@marquiz who else needs to review this? |
I was hoping to get +1 from some arm-person. ping @lubinszARM @zvonkok @pmundt |
Silent approvat it seems 😉 |
32-bit ARMv8 Crypto Extensions are exposed through AT_HWCAP2. IDIV is not an individual flag, but indicates both IDIVA and IDIVT are present.
Discovered this in the process of documenting canonical sources for #919. We don't really deal with 32-bit ARM, so this is untested.
This also conflicts with #914 but I presume that will go in first, and then I'll rebase this.
/cc @marquiz @lubinszARM