Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update WorkloadStatusComponent #3667

Merged
merged 5 commits into from
Mar 28, 2019
Merged

update WorkloadStatusComponent #3667

merged 5 commits into from
Mar 28, 2019

Conversation

ajatprabha
Copy link
Contributor

@ajatprabha ajatprabha commented Mar 17, 2019 •
edited
Loading

Work towards #3440

Preview:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot requested review from mhenc and PeWu March 17, 2019 13:09
@ajatprabha ajatprabha mentioned this pull request Mar 17, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 17, 2019 •
edited
Loading

Codecov Report

Merging #3667 into master will increase coverage by 0.51%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3667      +/-   ##
==========================================
+ Coverage   46.82%   47.33%   +0.51%     
==========================================
  Files         165      171       +6     
  Lines        7763     7922     +159     
  Branches       24       30       +6     
==========================================
+ Hits         3635     3750     +115     
- Misses       3906     3949      +43     
- Partials      222      223       +1
Impacted Files Coverage Δ
.../app/frontend/overview/workloadstatus/component.ts 100% <100%> (ø)
src/app/frontend/overview/component.ts 55.55% <50%> (ø)
...end/common/components/allocationchart/component.ts 73.33% <60%> (ø)
src/app/frontend/overview/helper.ts 94.11% <94.11%> (ø)
...rontend/common/components/resourcelist/groupids.ts 100% <0%> (ø)
src/app/frontend/common/resources/groupedlist.ts 38.88% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee9f3b...a841c0e. Read the comment docs.

@ajatprabha
Copy link
Contributor Author

ajatprabha commented Mar 17, 2019 •
edited
Loading

/assign @floreks

jeefy
jeefy requested changes Mar 17, 2019
View reviewed changes
Copy link
Member

@jeefy jeefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see the hover behavior seen on nvd3's site

The font used on the hover values is different from the rest of the page, and should be addressed.

One other thing I'd like to see are tests built. We're going to have to go through and write tests for everything eventually, and asking for tests up front now will help in the long run.

Looks pretty good overall. 😃

src/app/frontend/overview/workloadstatus/template.html Outdated Show resolved Hide resolved
@ajatprabha ajatprabha force-pushed the workload-statuses-3440 branch 2 times, most recently from 3e56eb9 to 4a5b9bf Compare March 20, 2019 11:39
@ajatprabha
Copy link
Contributor Author

@jeefy I'm thinking to address the font and hover behavior in another PR since it is more related to AllocationChartComponent. Is it okay?

@floreks
Copy link
Member

floreks commented Mar 21, 2019

Just a small comments. Nice work!

@ajatprabha
Copy link
Contributor Author

Result so far.
Screenshot from 2019-03-22 21-55-26

@floreks
Copy link
Member

floreks commented Mar 22, 2019

Looks great! I'll take a closer look later.

@floreks
Copy link
Member

floreks commented Mar 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajatprabha, floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1ab6931 into kubernetes:master Mar 28, 2019
@ajatprabha ajatprabha deleted the workload-statuses-3440 branch March 28, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeefy jeefy jeefy requested changes

@floreks floreks floreks approved these changes

@mhenc mhenc Awaiting requested review from mhenc

@PeWu PeWu Awaiting requested review from PeWu

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajatprabha @floreks @k8s-ci-robot @jeefy