Complete Angular migration

[maciaszczykm]

Things left to do:

• merge ng-migration to master branch
• deployment list and details (85% done; missing: new replica set list, hpa list in details @daminisatya )
• cron job list and details
• align actionbar actions with context actions in list menu for every resource
• graphs for cluster, nodes, overview, workloads, daemon sets, deployments, pods, rc, rs, and stateful sets (@eloyekunle)
• error handling (@floreks)
• remove skip button
• update README.md
• update wikis
• workload statuses for workload and overview page (@ajatprabha)
• tests
• check frontend_old for any leftovers
• solving all TODOs from the code
• manual tests and final code review
• release and annoucements

Related to #3152.

[junsionzhang]

is Angular migration done now and what is the plan ?

[floreks]

As you can see, there are still some pending tasks left to be implemented/fixed. Now, that the migration has been merged to master it will be easier to maintain and move forward with it.

[maciaszczykm]

@jeefy Do you have any updates about metrics container?

[jeefy]

@maciaszczykm It works! I'm still waiting on @DirectXMan12 to give it another look over (https://github.com/jeefy/metrics-sidecar) but after that I can PR in support for it (See https://github.com/kubernetes/dashboard/compare/master...jeefy:sidecar?expand=1)

I still have to pull in the angular migration changes and apply them to that branch though.

[ajatprabha]

I'd like to work on align actionbar actions with context actions in list menu for every resource task.
cc: @maciaszczykm

[daminisatya]

@maciaszczykm I have gone through the list of issues which are mentioned here. Can you please help me pick one feature in your experience which will be easier for someone who is a beginer to the project. (My dashboard is up and running!)

[maciaszczykm]

@daminisatya You can take a look at one of following:

• deployment list and details (85% done; missing: hpa list in details)
• cron job list and details (80% done; missing: inactive job list, trigger option in list, pause action)

We can discuss details here or at #sig-ui Slack.

[daminisatya]

@maciaszczykm This is amazing. Thank you for the pointers. I will buzz the UI channel on Slack!

[drazul]

Why you removed skip button on loging screen?
Are there a new way to avoid authentication?

All my team work on our local cluster before go to real cluster and we don't want to need to set up a new credential each time we need to use the dashboard.

[maciaszczykm]

@drazul Check enable-skip-login flag at https://github.com/kubernetes/dashboard/wiki/Dashboard-arguments.

[daminisatya]

@maciaszczykm This is my current dashboard and the deployment metrics it's showing. Took some decent amount of time getting the metrics on the dashboard. 😟 for deployment list and details (85% done; missing: hpa list in details)

Can you please further explain to me what exactly these hpa lists are, where to display the list details?

[maciaszczykm]

@daminisatya Of course. HPA is a shortcut from Horizontal Pod Autoscalers that we would like to display in the detail view of Deployments. So, when you enter the Deployments detail page you will be able to see all HPAs connected to it.

Implementation should be similar to what we have right now as we already display connected resources in the detail views of multiple resources.

Here you can find the endpoints for HPAs:

dashboard/src/app/backend/handler/apihandler.go

Lines 292 to 303 in 1f2007d

	apiV1Ws.Route(
	apiV1Ws.GET("/horizontalpodautoscaler").
	To(apiHandler.handleGetHorizontalPodAutoscalerList).
	Writes(horizontalpodautoscaler.HorizontalPodAutoscalerList{}))
	apiV1Ws.Route(
	apiV1Ws.GET("/horizontalpodautoscaler/{namespace}").
	To(apiHandler.handleGetHorizontalPodAutoscalerList).
	Writes(horizontalpodautoscaler.HorizontalPodAutoscalerList{}))
	apiV1Ws.Route(
	apiV1Ws.GET("/horizontalpodautoscaler/{namespace}/{horizontalpodautoscaler}").
	To(apiHandler.handleGetHorizontalPodAutoscalerDetail).
	Writes(horizontalpodautoscaler.HorizontalPodAutoscalerDetail{}))

Here is backend implementation:
https://github.com/kubernetes/dashboard/tree/master/src/app/backend/resource/horizontalpodautoscaler

And there you can find old pre-migration code:
https://github.com/kubernetes/dashboard/tree/master/src/app/frontend_old/horizontalpodautoscaler

If you need any more information don't hesitate to ask questions.

[maciaszczykm]

Here is how we included it in the past on the Deployment detail view:

dashboard/src/app/frontend/deployment/detail/detail.html

Lines 56 to 64 in 91a1efb

	<kd-content-card>
	<kd-content>
	<kd-horizontal-pod-autoscaler-card-list horizontal-pod-autoscaler-list="::ctrl.deploymentDetail.horizontalPodAutoscalerList">
	<kd-empty-list-text>
	[[There are currently no Horizontal Pod Autoscalers targeting this Deployment.|Text for horizontal pod autoscalers card zerostate in replica set details page.]]
	</kd-empty-list-text>
	</kd-horizontal-pod-autoscaler-card-list>
	</kd-content>
	</kd-content-card>

[eloyekunle]

@maciaszczykm re:

graphs for cluster, nodes, overview, workloads, daemon sets, deployments, pods, rc, rs, and stateful sets

I'll work on this.

• cluster
• nodes
• overview
• workloads
• daemon sets
• deployments
• pods
• replication controllers (rc)
• replica sets (rs)
• stateful sets

Were there graphs for these resources in the old frontend?

[maciaszczykm]

@eloyekunle Great! Could you also take a look on switch to c3 possibly?

Were there graphs for these resources in the old frontend?

Yes.

[eloyekunle]

Could you also take a look on switch to c3 possibly?

Yes, I'll look into into it.

[maciaszczykm]

@ajatprabha Can you add workload statuses to the workloads page too?

[ajatprabha]

Sure @maciaszczykm. I'm working on a PR.

[yinhaijiao]

Hi @maciaszczykm . Long time no contact. As I was busy with my work before, I didn't continue to help. Now I have some time. Is there anything I can do for you?

[maciaszczykm]

Split the issue to the smaller tasks in the https://github.com/kubernetes/dashboard/milestone/1.

/close

[k8s-ci-robot]

@maciaszczykm: Closing this issue.

In response to this:

Split the issue to the smaller tasks in the https://github.com/kubernetes/dashboard/milestone/1.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.