-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align actionbar actions with context actions #3514
Conversation
We have a misunderstanding here :) I was not so clear in the issue, so let's rephrase: To align items from context-menu (list view) and action bars (details view) you need to make sure that in both views we have same actions for every resource. For example for Pods I'd like to use logs, exec, edit and delete from list view and details view. It is not about CSS alignment, but if it works you can leave it and we will review. The real issue is a little bit more time consuming :) |
Okay, got it. I'll see if I can make this work and update the PR. |
Both menus should have same actions in detail and list views, right? |
835026a
to
5ca4a5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3514 +/- ##
=======================================
Coverage 48.31% 48.31%
=======================================
Files 165 165
Lines 8026 8026
Branches 43 43
=======================================
Hits 3878 3878
Misses 3866 3866
Partials 282 282 Continue to review full report at Codecov.
|
5ca4a5e
to
96be014
Compare
Thank you for your patience, I am reviewing it 🙂 |
/lgtm Great piece of work. What I like is that it is clean and code is in one place. Thanks a lot! We can iterate on it to make these actions more visible, but it is already good. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajatprabha, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @maciaszczykm 🙂 |
This PR is to align action-bar actions with context actions in list menu for every resource. WIP towards #3440