Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align actionbar actions with context actions #3514

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

ajatprabha
Copy link
Contributor

This PR is to align action-bar actions with context actions in list menu for every resource. WIP towards #3440

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@maciaszczykm
Copy link
Member

We have a misunderstanding here :) I was not so clear in the issue, so let's rephrase:

To align items from context-menu (list view) and action bars (details view) you need to make sure that in both views we have same actions for every resource.

For example for Pods I'd like to use logs, exec, edit and delete from list view and details view.

It is not about CSS alignment, but if it works you can leave it and we will review. The real issue is a little bit more time consuming :)

@ajatprabha
Copy link
Contributor Author

Okay, got it. I'll see if I can make this work and update the PR.

@ajatprabha
Copy link
Contributor Author

Both menus should have same actions in detail and list views, right?

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #3514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3514   +/-   ##
=======================================
  Coverage   48.31%   48.31%           
=======================================
  Files         165      165           
  Lines        8026     8026           
  Branches       43       43           
=======================================
  Hits         3878     3878           
  Misses       3866     3866           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d3aee...96be014. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2019
@maciaszczykm maciaszczykm self-assigned this Jan 28, 2019
@maciaszczykm
Copy link
Member

Thank you for your patience, I am reviewing it 🙂

@maciaszczykm
Copy link
Member

/lgtm
/approve

Great piece of work. What I like is that it is clean and code is in one place. Thanks a lot! We can iterate on it to make these actions more visible, but it is already good.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajatprabha, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3fc3fcb into kubernetes:master Feb 7, 2019
@ajatprabha
Copy link
Contributor Author

Thank you @maciaszczykm 🙂

@feloy feloy mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants