Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter option to disallow named returns #5455

Closed
bartsmykla opened this issue Dec 7, 2022 · 0 comments · Fixed by #5473
Closed

Add linter option to disallow named returns #5455

bartsmykla opened this issue Dec 7, 2022 · 0 comments · Fixed by #5473
Labels
area/ci-cd kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bartsmykla
Copy link
Contributor

bartsmykla commented Dec 7, 2022 •
edited
Loading

Description

As it's very easy to introduce hard to spot bugs like this one I believe we should disallow all named returns in our code base
@bartsmykla bartsmykla added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 7, 2022
@mmorel-35 mmorel-35 mentioned this issue Dec 8, 2022
Merged
12 tasks
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code area/ci-cd and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Dec 12, 2022
lahabana pushed a commit to lahabana/kuma that referenced this issue Jan 5, 2023
@mmorel-35 @lahabana
ci(lint): setup nonamedreturns linit in .golangci.yml
0745799 
And fix places where it was used

Fix kumahq#5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
lahabana pushed a commit that referenced this issue Jan 13, 2023
@mmorel-35
ci(lint): setup nonamedreturns linter (#5473)
b14c549 
And fix places where it was used

Fix #5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this issue Jan 14, 2023
@mmorel-35 @bartsmykla
ci(lint): setup nonamedreturns linter (kumahq#5473)
5eb2222 
And fix places where it was used

Fix kumahq#5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this issue Jan 14, 2023
@mmorel-35 @bartsmykla
ci(lint): setup nonamedreturns linter (kumahq#5473)
eafbc16 
And fix places where it was used

Fix kumahq#5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(lint): setup nonamedreturns linter
2 participants
@jakubdyszkiewicz @bartsmykla