Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): setup nonamedreturns linter #5473

Merged
merged 8 commits into from
Jan 13, 2023
Merged

ci(lint): setup nonamedreturns linter #5473

merged 8 commits into from
Jan 13, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 8, 2022 •
edited by lahabana
Loading

Fixes #5455

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
Copy link
Contributor

lahabana commented Dec 9, 2022

@mmorel-35 thx! I guess you are fixing the failures introduce next?

@mmorel-35
Copy link
Contributor Author

Hi @lahabana ,
Yes, I did just the golangci config for the moment, I'll do the fixes soon

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Dec 9, 2022 •
edited
Loading

HI @lahabana ,
That is a lot of files... Would there be any way to do it progressively ?

@mmorel-35 mmorel-35 marked this pull request as ready for review December 9, 2022 18:34
@mmorel-35 mmorel-35 requested review from a team, lobkovilya and lukidzi and removed request for a team December 9, 2022 18:34
@mmorel-35 mmorel-35 marked this pull request as draft December 9, 2022 18:39
@slonka
Copy link
Contributor

slonka commented Dec 12, 2022

That is a lot of files... Would there be any way to do it progressively ?

@mmorel-35 - this issue indicates that singlechecker (which nonamedreturns is based on) "take package patterns string". So I guess we could do this on a package basis?

@lahabana
Copy link
Contributor

@mmorel-35 what do you think about @slonka 's suggestion?

@mmorel-35 mmorel-35 marked this pull request as ready for review January 5, 2023 18:21
@lahabana
Copy link
Contributor

lahabana commented Jan 6, 2023

@lobkovilya and @lukidzi please prioritize this PR as it touches a lot of things and it's annoying to keep up to date :)

@lahabana lahabana enabled auto-merge (squash) January 6, 2023 08:06
@lahabana lahabana disabled auto-merge January 6, 2023 08:06
@lahabana lahabana enabled auto-merge (squash) January 6, 2023 08:06
mmorel-35 and others added 2 commits January 7, 2023 13:09
@mmorel-35
ci(lint): setup nonamedreturns linit in .golangci.yml
54c8fa0 
And fix places where it was used

Fix #5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@michaelbeaumont
refactor: make code without named returns more idiomatic
23d8877 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont mentioned this pull request Jan 11, 2023
Merged
12 tasks
michaelbeaumont
michaelbeaumont reviewed Jan 11, 2023
View reviewed changes
mk/generate.mk Outdated Show resolved Hide resolved
tools/xds-client/main.go Outdated Show resolved Hide resolved
michaelbeaumont and others added 5 commits January 12, 2023 10:20
@michaelbeaumont
fix: restore named returns for defer use case
1d68647 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: revert mk/generate.mk change
01dc911 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge remote-tracking branch 'origin/master' into issue-5455
b0d7543 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(pkg/util/net): fix Expected error
97b6524 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@lahabana
Merge branch 'master' into issue-5455
0214f49 
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@michaelbeaumont
Merge branch 'master' into issue-5455
7fc61c0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@lahabana lahabana merged commit b14c549 into kumahq:master Jan 13, 2023
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@mmorel-35 @bartsmykla
ci(lint): setup nonamedreturns linter (kumahq#5473)
5eb2222 
And fix places where it was used

Fix kumahq#5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@mmorel-35 @bartsmykla
ci(lint): setup nonamedreturns linter (kumahq#5473)
eafbc16 
And fix places where it was used

Fix kumahq#5455

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@bartsmykla bartsmykla bartsmykla approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add linter option to disallow named returns
5 participants
@mmorel-35 @lahabana @slonka @michaelbeaumont @bartsmykla