This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
refactor interfaces #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/own-channels
branch
from
33aecd4
to
2208622
Compare
raulk
reviewed
Jun 21, 2019
| } | ||
|
|
||
| for _, ch := range n.sinks { | ||
| ch.Send(eval) | ||
| ch <- event |
There was a problem hiding this comment.
We'll soon want to handle backpressure here, but it's fine for now.
|
Rectified my review above; apparently I can't read code on a Friday afternoon 😛 I'll release go-libp2p-core, then update go.mod here and merge. |
Kubuxu
reviewed
Jun 21, 2019
| typ := reflect.TypeOf(etyp) | ||
|
|
||
| if typ.Kind() != reflect.Ptr { | ||
| return nil, errors.New("subscribe called with non-pointer type") |
There was a problem hiding this comment.
This needs to close already created subscriptions.
There was a problem hiding this comment.
👍 yeah, since this is merged and released, could you open an issue for it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.