Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

eventbus interface changes #22

Merged
merged 3 commits into from
Jun 21, 2019
Merged

eventbus interface changes #22

merged 3 commits into from
Jun 21, 2019

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 21, 2019

@magik6k magik6k requested a review from raulk June 21, 2019 14:54
Kubuxu
Kubuxu reviewed Jun 21, 2019
View reviewed changes
event/bus.go Show resolved Hide resolved
raulk
raulk approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will need a release to pick it up in go-eventbus.

@raulk raulk changed the title EventBus interface changes eventbus interface changes Jun 21, 2019
@raulk raulk merged commit 786c4f4 into master Jun 21, 2019
@raulk raulk deleted the feat/event-refact branch June 21, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @raulk @Kubuxu