identify: make the protocol version configurable #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the protocolVersion field of the Idenfity protocol to be configured on the host. The current value is fixed for what appears to be for backwards compatibility with IPFS which makes it difficult for non-IPFS protocols to use the library. References: - libp2p#714 - libp2p#1137 - https://github.com/libp2p/rust-libp2p/blob/6855ab943bd7427a2135b46ad3d08f48fbf10872/protocols/identify/src/identify.rs#L125-L127
Fix an issue where the protocolVersion string for the Identify protocol was wrongly being assigned the agentVersion string.
Stebalien
approved these changes
Aug 31, 2022
| // XXX: Don't change this till 2020. You'll break all go-ipfs versions prior to | ||
| // 0.4.17 which asserted an exact version match. | ||
| const LibP2PVersion = "ipfs/0.1.0" | ||
| const DefaultProtocolVersion = "ipfs/0.1.0" |
There was a problem hiding this comment.
We should change this to libp2p sometime in the future, but we can leave it like this for now.
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the protocolVersion field of the Idenfity protocol to be
configured on the host. The current value is fixed for what appears to
be for backwards compatibility with IPFS which makes it difficult for
non-IPFS protocols to use the library.
References: