Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: make the protocol version configurable #1724

Merged
merged 3 commits into from
Sep 2, 2022
Merged

identify: make the protocol version configurable #1724

merged 3 commits into from
Sep 2, 2022

Commits on Aug 29, 2022

  1. Configure protocolVersion for Identify protocol 

    Allows the protocolVersion field of the Idenfity protocol to be
configured on the host. The current value is fixed for what appears to
be for backwards compatibility with IPFS which makes it difficult for
non-IPFS protocols to use the library.

References:
  - libp2p#714
  - libp2p#1137
  - https://github.com/libp2p/rust-libp2p/blob/6855ab943bd7427a2135b46ad3d08f48fbf10872/protocols/identify/src/identify.rs#L125-L127
    Tshaka Eric Lekholoane committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4c99423 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Fix protocol version assignment 

    Fix an issue where the protocolVersion string for the Identify protocol
was wrongly being assigned the agentVersion string.
    Tshaka Eric Lekholoane committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    734986f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Delete trailing whitespace

    Tshaka Eric Lekholoane committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4e0c2c5 View commit details
    Browse the repository at this point in the history