Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket: don't return transport.ErrListenerClosed on closing listener #2867

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jul 8, 2024

closes #2865

ErrListenerClosed is supposed to be returned by Accept when listener is closed.

@sukunrt sukunrt changed the title websocket: don't return transport.ErrListenerClose on closing listener websocket: don't return transport.ErrListenerClosed on closing listener Jul 8, 2024
@ineiti
Copy link

ineiti commented Jul 10, 2024

LGTM - That's more than I could do :)

Is the <- l.closed also fulfilled if the closing fails and returns an error?

@sukunrt
Copy link
Member Author

sukunrt commented Jul 15, 2024

@ineiti Yes, l.closed chan should always be closed provided you started listening on an address. This is always true if you're calling any of the public methods on the transport.

@sukunrt sukunrt merged commit fc0dd55 into master Jul 16, 2024
11 checks passed
@ineiti ineiti mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race while closing in 0.35.2
3 participants