src/connection: Return error from next_frame Future early

[mxinden]

The frame future might be ready with an Error from the underlying
socket (i.e. here libp2p-websocket). Though given that the result of the
control_command Future is handled first, on_control_command is called
despite frame having returned an Error. on_control_command itself may try
to write to the underlying socket, which will panic given that the socket
returned an error earlier via the frame Future.

Patch to validate suspicion in
libp2p/rust-libp2p#2598.

Note that I am not planning to merge this as is. This needs more refactoring in order to make it into master.

I would very much appreciate help testing this patch. You can add the override below to your Cargo.toml to compile your binary with the patch:

[patch.crates-io]
yamux = { git = 'https://github.com/mxinden/yamux', branch = "next-frame-error" }

Please double check your Cargo.lock to make sure the patched version is being used to compile your binary.

[jasl]

the patch should be

[patch.crates-io]
yamux = { git = 'https://github.com/mxinden/yamux', branch = "next-frame-error" }

[mxinden]

Correct. Thanks @jasl. Updated above.

[mxinden]

Closing here in favor of #138.