Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/connection: Return error from next_frame Future early #137

Closed
wants to merge 1 commit into from
Closed

src/connection: Return error from next_frame Future early #137

wants to merge 1 commit into from

Commits on Aug 1, 2022

  1. src/connection: Return error from next_frame Future early 

    > The `frame` future might be _ready_ with an `Error` from the underlying
socket (i.e. here `libp2p-websocket`). Though given that the result of the
`control_command` `Future` is handled first, `on_control_command` is called
despite `frame` having returned an `Error`. `on_control_command` itself may try
to write to the underlying socket, which will panic given that the socket
returned an error earlier via the `frame` `Future`.

Patch to validate suspicion in
libp2p/rust-libp2p#2598.
    @mxinden
    mxinden committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    25e5ee6 View commit details
    Browse the repository at this point in the history