Pluggable anchors select itests #4001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
halseth
commented
Feb 14, 2020
rpcserver.go
Outdated
| // regardless of channel type, add any anchor fees we are | ||
| // paying for the two anchors back to our balance if we are the | ||
| // initiator. | ||
| if channel.IsInitiator { |
There was a problem hiding this comment.
report real balance, anchors as separate field
halseth
commented
Feb 14, 2020
lnrpc/rpc.proto
Outdated
| outputs on the commitments, allowing fee bumping after a force close | ||
| transaction has been broadcast. | ||
| */ | ||
| int64 anchor_output_size = 26 [json_name = "anchor_output_size"]; |
halseth
commented
Feb 14, 2020
lnrpc/rpc.proto
Outdated
| @@ -1356,6 +1356,14 @@ message Channel { | |||
| */ | |||
| bool static_remote_key = 22 [json_name = "static_remote_key"]; | |||
|
|
|||
|
|
|||
| /** | |||
| If non-zero, then this channel uses a commitment format that has anchor | |||
There was a problem hiding this comment.
take into account one or two anchors on commitment?
halseth
commented
Feb 14, 2020
| @@ -498,3 +498,76 @@ func checkPaymentStatus(ctxt context.Context, node *lntest.HarnessNode, | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func createThreeHopNetwork(t *harnessTest, net *lntest.NetworkHarness, | |||
There was a problem hiding this comment.
move in separate (trivial) PR?
8 tasks
halseth
force-pushed
the
pluggable-anchors-select-itests
branch
5 times, most recently
from
02fe6ff
to
85a4d17
Compare
halseth
force-pushed
the
pluggable-anchors-select-itests
branch
2 times, most recently
from
b449f45
to
25852ef
Compare
|
As brought up in the other PR, we should also expand the tests for breaches as well. |
halseth
force-pushed
the
pluggable-anchors-select-itests
branch
from
25852ef
to
38073bd
Compare
halseth
force-pushed
the
pluggable-anchors-select-itests
branch
from
38073bd
to
0ac8689
Compare
To make it possible to run the for close test for multiple commit types, we extract ut into a subtest, where the two nodes get passed in.
Now that the force closure test has been extracted, spin up new nodes for each commit type, and ensure the test succeed for all types.
PURE CODE MOVE.
To make clear whcih sweep scenarios are actually being tested
This will let us set their commitment type for the subtest.
These tests exercise the different ways of sweeping a commitment, so we'll cover the modified scripts used for anchor commitments. The only change we need for the tests to pass is to not assert exactly which output is being swept, since this index depends on whether the anchors are there or not.
halseth
force-pushed
the
pluggable-anchors-select-itests
branch
from
0ac8689
to
d8e0324
Compare
|
Can be rebased on top of #4103 |
|
Superseded by #4073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests for a select set of integration tests with the channel type set to anchor:
These are selected since they together test establishing channels of this new type in combination with the previous channel types, sweeping of commitment outputs, and HTLC sweep scenarios.
The goal is to later enable the whole integration test suite for this channel type, but it requires changes to most notably the channel backup format and watchtower.
Builds on #3821