lntest/itest: select anchor commitment format and sweeping itests #4073
Conversation
joostjager
force-pushed
the
anchor-sweep-itest
branch
7 times, most recently
from
90e35c8
to
e9e1434
Compare
joostjager
force-pushed
the
anchor-sweep-itest
branch
8 times, most recently
from
bd16483
to
6844e87
Compare
|
Integration test times out on travis 50 minute max. Need #3924 |
joostjager
force-pushed
the
anchor-sweep-itest
branch
3 times, most recently
from
0fb5c7c
to
a852022
Compare
joostjager
changed the title
joostjager
force-pushed
the
anchor-sweep-itest
branch
7 times, most recently
from
c4d2927
to
f736a3f
Compare
|
Timeout issue solved for now because we only test two of the three formats. |
joostjager
force-pushed
the
anchor-sweep-itest
branch
from
f736a3f
to
4256189
Compare
|
|
||
| func closeChannelAndAssertType(ctx context.Context, t *harnessTest, | ||
| net *lntest.NetworkHarness, node *lntest.HarnessNode, | ||
| fundingChanPoint *lnrpc.ChannelPoint, anchors, force bool) *chainhash.Hash { |
There was a problem hiding this comment.
can just take commit type instead of the bool?
There was a problem hiding this comment.
yes, so the reason that I made it not the commit type, is that this function is also used for coop closes when no anchor is expected (even though the chan type is still anchors).
There was a problem hiding this comment.
Oh, because you don't have access to the force bool in assertChannelClosed?
There was a problem hiding this comment.
Yes that. I could add it probably. But it would also mean that all calls to these assertions need the commit type. Now I can get away by passing in false for anchors for all the existing tests, while when a type is expected, I would want to make sure that the actual channel type is passed in (legacy or tweakless).
lntest/itest/lnd_multi-hop_local_force_close_on_chain_htlc_timeout_test.go
Outdated
Show resolved
Hide resolved
joostjager
force-pushed
the
anchor-sweep-itest
branch
from
4256189
to
cf0b1ad
Compare
Fixes a subtle bug where the outer scope predErr was hidden when the return value of findForceClosedChannel was stored in a newly defined variable with the same name.
To facilitate debugging.
Co-authored-by: Johan T. Halseth <johanth@gmail.com>
Co-authored-by: Johan T. Halseth <johanth@gmail.com>
These tests exercise the different ways of sweeping a commitment, so we'll cover the modified scripts used for anchor commitments and spending the anchor itself by both parties. Co-authored-by: Johan T. Halseth <johanth@gmail.com>
joostjager
force-pushed
the
anchor-sweep-itest
branch
from
cf0b1ad
to
8628a98
Compare
|
|
||
| func closeChannelAndAssertType(ctx context.Context, t *harnessTest, | ||
| net *lntest.NetworkHarness, node *lntest.HarnessNode, | ||
| fundingChanPoint *lnrpc.ChannelPoint, anchors, force bool) *chainhash.Hash { |
There was a problem hiding this comment.
Oh, because you don't have access to the force bool in assertChannelClosed?
This PR adds integration tests for a select set of integration tests with the channel type set to anchor:
basic funding flow
channel force closure
test multi-hop htlc local force close immediate expiry
test multi-hop htlc receiver chain claim
test multi-hop local force close on-chain htlc timeout
test multi-hop remote force close on-chain htlc timeout
test multi-hop htlc local chain claim
test multi-hop htlc remote chain claim
These are selected since they together test establishing channels of this new type in combination with the previous channel types, sweeping of commitment outputs, and HTLC sweep scenarios.
The goal is to later enable the whole integration test suite for this channel type, but it requires changes to most notably the channel backup format and watchtower.
[desc copied from #4001]
Builds on #4103