Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Commit

Permalink
Fix TimeInterval test (#88)
Browse files Browse the repository at this point in the history
As of Swift 3 this test no longer implicitly converts Ints to Doubles.
This is still kind of an issue since that means this feature broke with
Swift 3, but that will be addressed with a future PR.
  • Loading branch information
Keith Smiley committed Nov 13, 2016
1 parent 3892335 commit 69c7e96
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
- Fix Xcode 8.1 `Any` -> `Any?` warning
[Keith Smiley](https://github.com/keith)
[#87](https://github.com/lyft/mapper/pull/87)
- Fix `TimeInterval` test
[Keith Smiley](https://github.com/keith)
[#88](https://github.com/lyft/mapper/pull/88)

# 5.0.0

Expand Down
4 changes: 2 additions & 2 deletions Tests/MapperTests/NormalValueTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ final class NormalValueTests: XCTestCase {
}
}

let test = try? Test(map: Mapper(JSON: ["time": 123]))
XCTAssertTrue(test?.string == 123)
let test = try? Test(map: Mapper(JSON: ["time": 123.0]))
XCTAssertTrue(test?.string == 123.0)
}

func testMappingMissingKey() {
Expand Down

0 comments on commit 69c7e96

Please sign in to comment.