This repository has been archived by the owner on May 17, 2024. It is now read-only.
Fix TimeInterval test #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
As of Swift 3 this test no longer implicitly converts Ints to Doubles. This is still kind of an issue since that means this feature broke with Swift 3, but that will be addressed with a future PR.
keith
force-pushed
the
ks/double-warning
branch
from
e14818e
to
fb7ebe5
Compare
|
The future PR: #89 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Swift 3 this test no longer implicitly converts Ints to Doubles.
This is still kind of an issue since that means this feature broke with
Swift 3, but that will be addressed with a future PR.