This repository has been archived by the owner on Jan 22, 2022. It is now read-only.
Git Plugin truncates changelog [JENKINS - 29977] #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential tracking is intended to track relevant and valuable use of the credential, not something as simple as using that credential in a form validation. Form validation is valuable for the user experience of the administrator, but it is not valuable enough to track the credential use in validating the form.
The comment is sufficient to explain why the implementation call is not used.
…sing-null-context-to-credentials JENKINS-44640 - Fix NPE checking legacy git SCM URL
Conflicts: pom.xml
Call User.getById when available
…ameterized trigger Arguably we should bump to a newer version, but proposing just the minimal change to pick up jenkinsci/parameterized-trigger-plugin@440065d
It is 6 years since the version range dependency was removed from parameterized trigger
…nd toString implementation requirements
…aseline version of Jenkins core
… by GitSCMSource should honour refspecs on clone and not fetch tags
Jdk 7 changes
Tests run very quickly and cover a few cases which are not tested elsewhere.
If the branch name is parameterized and the parameter is empty, then the workspace is not required for polling. If the branch name is empty, then a workspace is required. If the branch name contains a wildcard that is not '*/' in the first two characters, a workspace is required. If multiple branch names are provided, a workspace is required. If branch name is parameterized and parameter includes a wildcard, a workspace is not required.
Most non-Windows execution environments define the LOGNAME environment variable. When running the Jenkins Dockerfile-slim, it does not appear to define that environment variable on the master. Rather than create complicated searching for another environment variable whose value is valid as a branch name, we will skip this test if LOGNAME is not set. LOGNAME is set in enough contexts (like ci.jenkins.io and developer desktop machines and other test environments) that it is not a good use of time to embed additional logic into the test for a relatively rare case. Skip the test if the environment won't support the test.
…ME-in-test Skip LOGNAME dependent test if LOGNAME not defined
Branch source, branch API, and scm API typically. [Fix JENKINS-49160] update maintainer information
…tainer Add Stephen Connolly as a maintainer
…configuring the truncation of commit messages or not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark,
I was unable to do some of the testing that I would have liked. I was hoping that you would be able to try to build my code on your system, then hopefully send me the .hpi file. I know there are tests yet to be written so this pull request is by no means final, but it seemed like a good way to get the code in your hands.
Thanks again for all the support on this, I hope we can find a solution to these build issues that does not rely on your environment.
Chris