Drop reference_sha column
#3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
==========================================
- Coverage 66.44% 66.39% -0.05%
==========================================
Files 497 499 +2
Lines 53746 53792 +46
==========================================
+ Hits 35710 35717 +7
- Misses 14486 14545 +59
+ Partials 3550 3530 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
May 16, 2023
| return fmt.Errorf("failed to query duplicate event ids") | ||
| } | ||
| if count > 0 { | ||
| return fmt.Errorf("unable to drop column, as there are duplicate event ids") |
There was a problem hiding this comment.
This is unfortunate as it would prevent people from upgrading Dendrite. Can we instead mix together the event nids for the affected rows? E.g given:
event_id | sha256 | nids
$foo | abc123 | [2,4]
$foo | def456 | [2,3]
replace it with:
$foo | [2,3,4]
?
kegsay
approved these changes
May 24, 2023
| Up: deltas.UpDropEventReferenceSHAPrevEvents, | ||
| }, | ||
| }...) | ||
| logrus.Infof("cName: %s", cName) |
S7evinK
added a commit
that referenced
this pull request
May 30, 2023
... as they could fail if there are duplicate events in `roomserver_previous_events`. This fixes the migration by trying to combine the `event_nids` if possible (same room) as mentioned by @kegsay in #3083 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to matrix-org/gomatrixserverlib#383