Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the UpDropEventReferenceSHAPrevEvents migration #3087

Merged
merged 3 commits into from
May 30, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented May 26, 2023

... as they could fail if there are duplicate events in roomserver_previous_events.
This fixes the migration by trying to combine the event_nids if possible (same room) as mentioned by @kegsay in #3083 (comment)

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label May 26, 2023
@S7evinK S7evinK requested a review from a team as a code owner May 26, 2023 07:28
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 45.94% and project coverage change: -0.12 ⚠️

Comparison is base (3dcca40) 66.36% compared to head (02ff5ab) 66.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   66.36%   66.25%   -0.12%     
==========================================
  Files         499      499              
  Lines       53809    53908      +99     
==========================================
+ Hits        35710    35715       +5     
- Misses      14545    14600      +55     
- Partials     3554     3593      +39     
Flag Coverage Δ
unittests 49.96% <45.94%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...stgres/deltas/20230516154000_drop_reference_sha.go 43.24% <45.45%> (+5.31%) ⬆️
...qlite3/deltas/20230516154000_drop_reference_sha.go 40.62% <46.42%> (+40.62%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IngwiePhoenix
Copy link

Any chance this is merged soon? Been rolling around in the commit history to find a good one to use to temporarily fix #3091 ...

@S7evinK S7evinK linked an issue May 30, 2023 that may be closed by this pull request
@S7evinK S7evinK merged commit 61341ac into main May 30, 2023
@S7evinK S7evinK deleted the fix-drop-reference-migration branch May 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reference_sha256 broke my server.
2 participants