Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve TraceExplorer #2319

Closed
mgronover opened this issue Nov 9, 2023 · 0 comments
Closed

Fix and improve TraceExplorer #2319

mgronover opened this issue Nov 9, 2023 · 0 comments
Assignees
@mgronover

Comments

@mgronover
Copy link
Member

mgronover commented Nov 9, 2023 •
edited
Loading

The TraceExplorer:

  • is not always refreshing its content
  • should allow customers to select and use their own filters on the traced tree nodes
  • should automatically update it's content when the filtering mode was change
@mgronover mgronover self-assigned this Nov 9, 2023
@mgronover mgronover changed the title Improve TraceExplorer Fix and improve TraceExplorer Nov 9, 2023
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: Extracted two method from getChildren(.) #2319
9c10f8e
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: Simplified method #2319
21cc2ae
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: Simplified method getting filtered childTraces #2319
9263d0d 
No need to get descendants with itself aka "+".
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: [WIP] Refactored filtering as an part of the options.
0e266e8 
#2319
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: [WIP] Added popup menu for filtering #2319
adf04ff
mgronover added a commit that referenced this issue Nov 9, 2023
@mgronover
ComputationTrace: [WIP] Fixed update of trace tree #2319
f0441ad
mgronover added a commit that referenced this issue Nov 14, 2023
@mgronover
ComputationTrace: [WIP] Fixed tree folding and unfolding #2319
60bf965
mgronover added a commit that referenced this issue Nov 14, 2023
@mgronover
ComputationTrace: [WIP] Replaced Popupmenu by non modal dialog #2319
c2880f7
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: Extracted two method from getChildren(.) #2319
8c7ad28
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: Simplified method #2319
e9ef315
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: Simplified method getting filtered childTraces #2319
082b4dc 
No need to get descendants with itself aka "+".
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: [WIP] Refactored filtering as an part of the options.
6a2a5fc 
#2319
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: [WIP] Added popup menu for filtering #2319
d3698a7
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: [WIP] Fixed update of trace tree #2319
4323a17
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: [WIP] Fixed tree folding and unfolding #2319
6fad21e
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: [WIP] Replaced Popupmenu by non modal dialog #2319
2ab7846
mgronover added a commit that referenced this issue Nov 15, 2023
@mgronover
ComputationTrace: Dialog now non modal and always on top #2319
2cdb02e
mgronover added a commit that referenced this issue Nov 21, 2023
@mgronover
ComputationTrace: Fixed NPE #2319
4d6f528
mgronover added a commit that referenced this issue Nov 21, 2023
@mgronover
ComputationTrace: Fixed possible endless loop when a used filter is n…
8ec3162 
…ot avoiding it and did massive cleanups #2319
mgronover added a commit that referenced this issue Nov 21, 2023
@mgronover
ComputationTrace: Added preselection of used filters #2319
27b848e
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: corrected default filter (ITracerFrame) #2319
7cce204
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: no more lazy creation of children in ComputationTra…
c464962 
…ce the interface requires it anyway. Further cleanups #2319
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: Renamed actions to clearify the intention of them #…
a9e0a42 
…2319
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: Renamed both default filter #2319
24d3693
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: Updated CHANGELOG.md and disabled showing of root t…
119d1b6 
…he node #2319
@mgronover mgronover mentioned this issue Nov 22, 2023
Merged
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: Updated build script #2319
7baa44f
mgronover added a commit that referenced this issue Nov 22, 2023
@mgronover
ComputationTrace: Ensure at least one selected (i.e. active) filter o…
2750767 
…n startup #2319
mgronover added a commit that referenced this issue Nov 23, 2023
@mgronover
ComputationTrace: fixed some typos #2319
2751942
mgronover added a commit that referenced this issue Nov 23, 2023
@mgronover
ComputationTrace: fixed some UI issues #2319
b832571
mgronover added a commit that referenced this issue Nov 23, 2023
@mgronover
ComputationTrace: Removed getTargetNode() from ITraceRecord #2319
e2919f6
mgronover added a commit that referenced this issue Nov 23, 2023
@mgronover
ComputationTrace: Further cleanups and UI improvements #2319
e6b5560
@mgronover mgronover mentioned this issue Nov 27, 2023
Closed
mgronover added a commit that referenced this issue Nov 27, 2023
@mgronover
Fix and improve trace explorer (#2328)
9dfc820 
* ComputationTrace: Added popup menu for filtering #2319

- Fixed update and un-/folding of trace tree
- Fixed NPE
- Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups
- No more lazy creation of children in ComputationTrace.
mgronover pushed a commit that referenced this issue Nov 27, 2023
@github-actions
Fix and improve trace explorer (#2328) (#2330)
e58d515 
* ComputationTrace: Added popup menu for filtering #2319

- Fixed update and un-/folding of trace tree
- Fixed NPE
- Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups
- No more lazy creation of children in ComputationTrace.
mgronover added a commit that referenced this issue Dec 14, 2023
@github-actions @mgronover @alexanderpann
Merge maintenance/mps20213 into maintenance/mps20222 (#2343)
1cadcb9 
* Fix and improve trace explorer (#2328)

* ComputationTrace: Added popup menu for filtering #2319

- Fixed update and un-/folding of trace tree
- Fixed NPE
- Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups
- No more lazy creation of children in ComputationTrace.

* Automatically remove assessment result entries with invalid references

* Fix typo in changelog

* Update to 2021.3.5

* Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335)

* ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329

* ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342)

* interpreter: generalize the evaluate methods into one method with options

---------

Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com>
Co-authored-by: Alexander Pann <apann@itemis.com>
Co-authored-by: Michael Gronover <mgronover@itemis.com>
Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mgronover added a commit that referenced this issue Dec 14, 2023
@github-actions @mgronover @alexanderpann
Merge maintenance/mps20213 into maintenance/mps20222 (#2343) (#2345)
f0c4f91 
* Fix and improve trace explorer (#2328)

* ComputationTrace: Added popup menu for filtering #2319

- Fixed update and un-/folding of trace tree
- Fixed NPE
- Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups
- No more lazy creation of children in ComputationTrace.

* Automatically remove assessment result entries with invalid references

* Fix typo in changelog

* Update to 2021.3.5

* Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335)

* ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329

* ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342)

* interpreter: generalize the evaluate methods into one method with options

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com>
Co-authored-by: Alexander Pann <apann@itemis.com>
Co-authored-by: Michael Gronover <mgronover@itemis.com>
Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com>
mgronover added a commit that referenced this issue Jan 16, 2024
@github-actions @mgronover
@alexanderpann @sergej-koscejev
Merge maintenance/mps20213 into maintenance/mps20222 (#2353)
2ea0ea1 
* Fix and improve trace explorer (#2328)

* ComputationTrace: Added popup menu for filtering #2319

- Fixed update and un-/folding of trace tree
- Fixed NPE
- Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups
- No more lazy creation of children in ComputationTrace.

* Automatically remove assessment result entries with invalid references

* Fix typo in changelog

* Update to 2021.3.5

* Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335)

* ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329

* ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342)

* interpreter: generalize the evaluate methods into one method with options

* core.base: run assessement result entry removal under write acces in EDT

With the previous implementation, the removed node didn't show up on the left side of the diff view.

* mpsutil.contextactions: do not update the tool when the node is null

* Use reusable automerge workflow

* mpsutil.interpreter: add a dummy computation trace when the computation trace is not available

---------

Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com>
Co-authored-by: Alexander Pann <apann@itemis.com>
Co-authored-by: Michael Gronover <mgronover@itemis.com>
Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sergej Koščejev <sergej@koscejev.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgronover mgronover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

bugfix/FixAndImproveTraceExplorer mbeddr/mbeddr.core
2 participants
@mgronover @alexanderpann