ComputationTrace: Fixed argument for @NotNull parameter must not be n… #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpann
approved these changes
Dec 13, 2023
mgronover
deleted the
bugfix/2341-traceexplorer-has-notnull-parameter-exception
branch
mgronover
added a commit
that referenced
this pull request
Dec 14, 2023
* Fix and improve trace explorer (#2328) * ComputationTrace: Added popup menu for filtering #2319 - Fixed update and un-/folding of trace tree - Fixed NPE - Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups - No more lazy creation of children in ComputationTrace. * Automatically remove assessment result entries with invalid references * Fix typo in changelog * Update to 2021.3.5 * Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335) * ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329 * ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342) * interpreter: generalize the evaluate methods into one method with options --------- Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com> Co-authored-by: Alexander Pann <apann@itemis.com> Co-authored-by: Michael Gronover <mgronover@itemis.com> Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mgronover
added a commit
that referenced
this pull request
Dec 14, 2023
* Fix and improve trace explorer (#2328) * ComputationTrace: Added popup menu for filtering #2319 - Fixed update and un-/folding of trace tree - Fixed NPE - Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups - No more lazy creation of children in ComputationTrace. * Automatically remove assessment result entries with invalid references * Fix typo in changelog * Update to 2021.3.5 * Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335) * ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329 * ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342) * interpreter: generalize the evaluate methods into one method with options --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com> Co-authored-by: Alexander Pann <apann@itemis.com> Co-authored-by: Michael Gronover <mgronover@itemis.com> Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com>
mgronover
added a commit
that referenced
this pull request
Jan 16, 2024
* Fix and improve trace explorer (#2328) * ComputationTrace: Added popup menu for filtering #2319 - Fixed update and un-/folding of trace tree - Fixed NPE - Fixed possible endless loop when a used filter is not avoiding it and did massive cleanups - No more lazy creation of children in ComputationTrace. * Automatically remove assessment result entries with invalid references * Fix typo in changelog * Update to 2021.3.5 * Bugfix/2329 follows up 2319 further improvements for the trace explorer (#2335) * ComputationTrace: improved filter interface and refactored handling of options used by the TraceTab #2329 * ComputationTrace: Fixed argument for @NotNull parameter must not be null #2341 (#2342) * interpreter: generalize the evaluate methods into one method with options * core.base: run assessement result entry removal under write acces in EDT With the previous implementation, the removed node didn't show up on the left side of the diff view. * mpsutil.contextactions: do not update the tool when the node is null * Use reusable automerge workflow * mpsutil.interpreter: add a dummy computation trace when the computation trace is not available --------- Co-authored-by: Michael Gronover <38247916+mgronover@users.noreply.github.com> Co-authored-by: Alexander Pann <apann@itemis.com> Co-authored-by: Michael Gronover <mgronover@itemis.com> Co-authored-by: Alexander Pann <88385944+alexanderpann@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sergej Koščejev <sergej@koscejev.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: 2341
just fixed that exception.