Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-710: Code value picklists type ahead search #1148

Merged
merged 4 commits into from
Apr 4, 2024
Merged

ACAS-710: Code value picklists type ahead search #1148

merged 4 commits into from
Apr 4, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 3, 2024 •
edited
Loading

Description

  • See related acas-roo-server changes ACAS-710: Code value picklists type ahead search #1148
  • Updated code table acas form widget to type ahead search rather than pre-fetch all picklist items.
  • In the case that there is a selected value, it will fetch the selected value only so that the intial value will be set.

Related Issue

ACAS-710

How Has This Been Tested?

  • Ran acasclient tests to verify compatability.
  • Uploaded thousands of data column/ column tree ls_type / ls_kind values to ddict value and verified the code table fields behaved properly in Experiment editor and protocol editor as well as those in each of the endpoint manage fields.

Demo video
demo

@brianbolt brianbolt mentioned this pull request Apr 4, 2024
Merged
brianbolt
brianbolt commented Apr 4, 2024
View reviewed changes
modules/CodeTablesAdmin/src/server/routes/CodeTablesAdminRoutes.coffee Show resolved Hide resolved
modules/CodeTablesAdmin/src/server/routes/CodeTablesAdminRoutes.coffee Show resolved Hide resolved
modules/Components/src/client/ACASFormFields.coffee Show resolved Hide resolved
modules/Components/src/client/ACASFormFields.coffee Show resolved Hide resolved
modules/Components/src/client/PickList.coffee Show resolved Hide resolved
modules/Components/src/client/PickList.coffee Show resolved Hide resolved
modules/Components/src/server/routes/CodeTableServiceRoutes.coffee Show resolved Hide resolved
modules/Components/src/server/routes/CodeTableServiceRoutes.coffee Show resolved Hide resolved
modules/ServerAPI/src/server/CustomerSpecificServerFunctions.coffee Show resolved Hide resolved
bffrost
bffrost approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the thought you put into backward compatibility and some of the minor cleanup you've done along the way.

modules/Components/src/client/PickList.coffee Show resolved Hide resolved
modules/CodeTablesAdmin/src/server/routes/CodeTablesAdminRoutes.coffee Show resolved Hide resolved
@brianbolt brianbolt merged commit 32dff0f into release/2024.1.x Apr 4, 2024
2 checks passed
@brianbolt brianbolt mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@dalejerikson dalejerikson Awaiting requested review from dalejerikson

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost