Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-769: Fix Bulkloader picklists by only using new type ahead when a url is provided to selection #1156

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 25, 2024

Description

  • Fix for Bulkloader picklists not loading introduced by ACAS-710
  • Bulkhead picklist collection does not provide a url so URLs are being formed like this:
    • /undefined?labelTextSearchTerm=Lo&maxHits=100&term=Lo&q=Lo and getting 404s
  • The fix is to only use the url if it is set on the collection model.

Related Issue

ACAS-769

How Has This Been Tested?

Using breakpoints verified that Protocol Endpoint manager picklists use the Ajax call and function properly.
Using breakpoints verified that CmpdReg bulkloader whose collection is preemptively fetched and does not have a URL, does not try to issue additional Ajax calls and the select2 widget is populated and. works correctly.

Copy link
Contributor

@dalejerikson dalejerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianbolt brianbolt merged commit 9485335 into release/2024.1.x Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants