Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator.cookiesEnabled - Safari 18 fix #24402

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Navigator.cookiesEnabled - Safari 18 fix #24402

merged 1 commit into from
Sep 10, 2024

Conversation

hamishwillee
Copy link
Collaborator

Safari 18 fixes a long standing bug where Navigator.cookiesEnabled could return true in some conditions where cookies are blocked.

Fixed navigator.cookieEnabled to return false when cookies are blocked. (121284878)

I fixed this by calling the old implementation partial and adding a new feature.

This is related to mdn/content#35725

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 10, 2024
@hamishwillee hamishwillee mentioned this pull request Sep 10, 2024
Merged
Elchi3
Elchi3 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit 9af8def into mdn:main Sep 10, 2024
5 checks passed
@hamishwillee hamishwillee deleted the cookieEnabled branch September 12, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @Elchi3