Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator: cookieEnabled warning regarding Safari is outdated #32845 #35725

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

kaushik95
Copy link
Contributor

Description

Fixes issue #32845

Motivation

I'm interested in solving issues.

Additional details

Related issues and pull requests

"Fixes #32845"

Signed-off-by: Kowshik BV <kowshik.bv@fmr.com>
@kaushik95 kaushik95 requested a review from a team as a code owner September 3, 2024 15:41
@kaushik95 kaushik95 requested review from Elchi3 and removed request for a team September 3, 2024 15:41
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Sep 3, 2024
@Josh-Cena Josh-Cena requested review from hamishwillee and removed request for Elchi3 September 3, 2024 16:13
@Josh-Cena
Copy link
Member

Josh-Cena commented Sep 3, 2024

Tagging Hamish since I think it's related to cookie privacy. Especially the note below that talks about experimental Firefox—maybe these changes should be elaborated on?

@hamishwillee
Copy link
Collaborator

I'll look on Friday. Thanks @Josh-Cena @kaushik95

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but this is not the right fix - all this text should be removed and the information should be added to the compatibility data.
I am confirming the best way to do that and will update this afterwards.

@hamishwillee hamishwillee self-assigned this Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Preview URLs

(comment last updated: 2024-09-11 02:58:58)

@hamishwillee
Copy link
Collaborator

@kaushik95 I've added two suggestions to remove the note altogether - can you please accept them (your github branch isn't set up to take changes)?

Then we can merge this once mdn/browser-compat-data#24402 goes in.

Note, we don't need the info about IE anymore, so once this is in the compatibility data, the whole note isn't needed.

Removed note section as it is not needed.

Signed-off-by: kaushik95 <kaushik.19995@gmail.com>
@kaushik95
Copy link
Contributor Author

@hamishwillee - Removed the note altogether.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@hamishwillee hamishwillee merged commit 3fdf7ec into mdn:main Sep 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigator: cookieEnabled warning regarding Safari is outdated
3 participants