Feat: add the ability to add in additional route properties #1080
Conversation
|
For context, we tried various solutions in https://github.com/nearform/mercurius-dynamic-schema to avoid extend core's functionality to achieve what we needed, and eventually realized that with this simple change in mercurius we'd have to get rid of unnecessary complications (and duplications) in our code. Hence we're proposing this change. |
Will do |
There was a problem hiding this comment.
See inline comments. Plus, we should also include this in the documentation https://mercurius.dev/#/docs/api/options?id=mercurius
also relevant changes to the types for the same
|
@mcollina if you could take another look please |
|
@mcollina whenever you get time |
|
Can somebody do a release? Speaking of which, is there an established way to do releases in this package (or the rest of the ecosystem)? If not, we shall consider introducing one @Eomm |
|
Cannot release - I'm not part of the |
|
@Eomm you should be then! In any case I was looping you in mostly to check if you had settled on anything with Fastify |
|
Can anybody do a release of mercurius? We are waiting for this feature to be released to start using it in one of our repos. |
Changes
ability to add and modify route properties to modify how the routes might behave. One example is to be able to create a schema split which https://github.com/nearform/mercurius-dynamic-schema/ tries to achieve.
Reasoning
Helps close nearform/mercurius-dynamic-schema#4