Refactor: Delegate all handling to core

[barelyhuman]

Changes

• Modifies the implementation to let core handle the separation (depends on Extend with route props barelyhuman/mercurius#1 ]

Test Modifications

• All tests now use method and body type as supported by the core instead of re-implementing their own details
• Modify tests to now have proper errors instead of coded anomalies

Upstream Dependency: mercurius-js/mercurius#1080
Closes #4

[simoneb]

I like this approach more than the previous attempts 👌

[simoneb]

Remind me again why we needed POST instead of GET and why now GET is fine?

[barelyhuman]

Remind me again why we needed POST instead of GET and why now GET is fine?

I don't know why we needed POST, i thought there was a reason for it. I knew why the core was using POST though

Now it's fine since I found out that there were no specific reasons for the decision to use POST.
Since, the core registers both GET and POST requests and will handle persisted queries on both GET and POST, it's okay to do this.

[simoneb]

LGTM, clearly we can't merge this until we land the upstream PR.

[simoneb]

@barelyhuman after updating the latest version of mercurius, which includes the change we needed, CI is failing. Not sure if you have a chance to look into this, but there must be something that was overlooked here.

[barelyhuman]

It seems to be reusing the existing mercurius instance, a teardown should help. I'll check it out in a bit

[simoneb]

It seems to be reusing the existing mercurius instance, a teardown should help. I'll check it out in a bit

Thanks 🙏

[barelyhuman]

should be additionalRouteOptions, I don't have push access to the repo anymore

[simoneb]

ah thanks, good catch 👌