🌱 fix hack scripts to run locally again #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/L
tuminoid
force-pushed
the
tuomo/fix-local-hack-scripts
branch
from
3217f5a
to
f93b1d6
Compare
|
/cc @kashifest @mquhuy |
tuminoid
force-pushed
the
tuomo/fix-local-hack-scripts
branch
2 times, most recently
from
eb06131
to
897843b
Compare
kashifest
reviewed
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
elfosardo
reviewed
Jun 28, 2024
tuminoid
force-pushed
the
tuomo/fix-local-hack-scripts
branch
from
897843b
to
72b5a7b
Compare
Fix hack scripts to run locally again. We have some Git permissions
issues, formatting issues, deprecated linters, bad Go configs, custom
mount points etc. Now it should be cleaner, runs on Linux and Mac
equally (zsh can't handle "${@}" for example)...
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
tuminoid
force-pushed
the
tuomo/fix-local-hack-scripts
branch
from
72b5a7b
to
bf11d60
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hack scripts to run locally again. We have some Git permissions issues, formatting issues, deprecated linters, bad Go configs, custom mount points etc. Now it should be cleaner, runs on Linux and Mac equally (zsh can't handle "${@}" for example)...