Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 make /workdir a variable in hack scripts #1820

Merged
merged 1 commit into from
Jul 1, 2024
Merged

🌱 make /workdir a variable in hack scripts #1820

merged 1 commit into from
Jul 1, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jul 1, 2024

Adding same improvement as suggested and added in BMO PR. CAPM3 base PR merged already, so adding it as separate one on top to keep scripts in sync.

@tuminoid
make /workdir a variable in hack scripts
fc17769 
Adding same improvement as suggested and added in BMO PR. CAPM3 base
PR merged already, so adding it as separate one on top.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jul 1, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

tuminoid commented Jul 1, 2024

/cc @mboukhalfa @Rozzii @kashifest

Sunnatillo
Sunnatillo reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sunnatillo
Sunnatillo approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
Rozzii
Rozzii reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@metal3-io-bot metal3-io-bot merged commit 7585960 into metal3-io:main Jul 1, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/make-workdir-to-variable branch July 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@kashifest kashifest Awaiting requested review from kashifest

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @Rozzii @Sunnatillo