Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User guide: document RAID #453

Merged
merged 1 commit into from
Jul 2, 2024
Merged

User guide: document RAID #453

merged 1 commit into from
Jul 2, 2024

Conversation

dtantsur
Copy link
Member

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2024
@MahnoorAsghar
Copy link

LGTM!

@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@derekhiggins: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, great addition to documentation. Some minor nits.

docs/user-guide/src/bmo/raid.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/raid.md Outdated Show resolved Hide resolved
@dtantsur
User guide: document RAID
4e16e6b 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

dtantsur commented Jul 1, 2024

@tuminoid done, please check

@tuminoid
Copy link
Member

tuminoid commented Jul 1, 2024

@tuminoid done, please check

/lgtm
Thanks!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Rozzii
Rozzii reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dtantsur
Copy link
Member Author

dtantsur commented Jul 2, 2024

/cc @kashifest @zaneb

kashifest
kashifest reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@metal3-io-bot metal3-io-bot merged commit ecf6bac into metal3-io:main Jul 2, 2024
8 checks passed
@dtantsur dtantsur deleted the raid branch July 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@kashifest kashifest kashifest left review comments

@MahnoorAsghar MahnoorAsghar MahnoorAsghar left review comments

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dtantsur @MahnoorAsghar @derekhiggins @metal3-io-bot @tuminoid @Rozzii @kashifest