Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Activity #14

Merged
merged 12 commits into from
Dec 13, 2023
Merged

deprecate Activity #14

merged 12 commits into from
Dec 13, 2023

Conversation

brynnz22
Copy link
Collaborator

@brynnz22 brynnz22 commented Dec 13, 2023

Regarding issue: microbiomedata#1552

  • Remove the Activity class from the schema
  • Move Activity slots over to WorkflowExecutionActivity class
  • change activity_set slot for the Database class to workflow_execution_set
  • Change references like domain and range values from Activity to WorkflowExecutionActivity

@brynnz22 brynnz22 merged commit a695414 into main Dec 13, 2023
2 checks passed
@brynnz22 brynnz22 deleted the 1552-deprecate-Activity branch December 13, 2023 22:36
@brynnz22
Copy link
Collaborator Author

brynnz22 commented Dec 15, 2023

will not require a migration

@brynnz22
Copy link
Collaborator Author

brynnz22 commented Apr 19, 2024

I guess this will actually need a migration because we have a collection called activity_set in Mongo and this renames it to workflow_execution_set. Though it is an empty collection in Mongo, so it seems like a bit of a silly migration. @turbomam @eecavanna. Does this actullay need a migration?

@brynnz22 brynnz22 added the migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. label Apr 19, 2024
@brynnz22
Copy link
Collaborator Author

I can add this bit to the migrator that already exists for renaming collections.

@brynnz22 brynnz22 changed the title 1552 deprecate activity 1552 deprecate Activity Apr 19, 2024
@brynnz22 brynnz22 changed the title 1552 deprecate Activity deprecate Activity Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-needed After applying this schema change, some valid data may become invalid. Data migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants