Edit slots and usages to accommodate multiple detection configurations for single MassSpectrometry
instance
#141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue here: microbiomedata#1910
MassSpectrometry
class needs some slots to be multivalued to better describe the data generation process, particularly for LC-lipidomics samples.The following slots should be able to be multivalued (and therefore the slot names should change to be plural) and their definitions and usage updated as necessary
resolution_category
->resolution_categories
mass_analyzer
->mass_analyzers
mass_spectrum_collection_mode
->mass_spectrum_collection_modes
Note that this is independent of #130 (creation of
Configuration
class etc). Wherever the slots end up (onMassSpectometry
orMassSpectrometryConfiguration
), they need to be able to multivalued as demonstrated in the second entry in https://github.com/microbiomedata/berkeley-schema-fy24/blob/massspec_slot_updates/src/data/valid/Database-mass-spectrometry.yaml.I will update #130 once this change is merged into main on this fork.