Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator to remove designated_class slot #172

Merged
merged 4 commits into from
May 21, 2024

Conversation

brynnz22
Copy link
Collaborator

This migrator removes the designated_class slot from all collections that use it.

This migrator was missed because there was no specific PR that mentioned it, but I believe it was probably part of adding the type slot requirement PR. I labeled this migrator as unknown. Let me know if you want to change it.

@eecavanna
Copy link

I'm OK with unknown in the name for now (given that it's the only migrator with that in its name).

I will be renaming all the migrators soon so that their order is indicated by their names. I'm still deciding on a naming convention, but it may be something like this:

migrator_from_10_2_0_to_11_0_0_A.py
migrator_from_11_0_0_A_to_11_0_0_B.py
migrator_from_11_0_0_B_to_11_0_0_C.py
# ...
migrator_from_11_0_0_K_to_11_0_0.py

@eecavanna
Copy link

I reviewed this draft PR. Its contents so far, look good to me.

@brynnz22 brynnz22 marked this pull request as ready for review May 21, 2024 19:34
Copy link

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@turbomam turbomam merged commit 5f616a1 into main May 21, 2024
2 checks passed
@eecavanna eecavanna deleted the migrator_remove_designated_class branch June 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants