Conflict resolved backmerge #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update range for was_informed_by
Add slot usage for was_informed_by to add structured_syntax
Remove structured_pattern on was_informed_by until re-iding is complete.
…_generated_by refine-was_generated_by
…ase-class-has-two-slots-named-functional_annotation_agg deduplicate Database slots
…ublish-action-version Do not pin to a specific version of pypa/gh-action-pypi-publish
…ublish-action-version-part-2 Fix version specifier for pypa/gh-action-pypi-publish
…xamples to test id pattern constraints, update id_version pattern match to enforce it as a single dot followed by a digit
…me_seequencing_activity_json.yaml
…obiomedata/berkeley-schema-fy24 into conflict-resolved-backmerge
…llow for DataGeneration and WorkflowExeuction identifiers
…their own collections so we should not refer to the abstract collection
Database-interleaved still cheating
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
| has_output: | ||
| - nmdc:22afa3d49b73eaec2e9787a6b88fbdc3 | ||
| - generic:xxx |
There was a problem hiding this comment.
@turbomam generic:xxx should not be allowed. has_output should have a structured pattern for a data object value here. In some cases this is currently populated with None which cause ref integrity issues so we'll need to allow that for now too. This means we missed fixing this class in nmdc-schema.
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
aclum
reviewed
Jun 4, 2024
| interpolated: true | ||
| has_input: | ||
| structured_pattern: | ||
| syntax: "{id_nmdc_prefix}:(bsm|procsm)-{id_shoulder}-{id_blade}$" | ||
| interpolated: true |
There was a problem hiding this comment.
we are missing an has_output pattern. This should be a DataObject or 'None' (to accommodate existing data in mongo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.