Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template specific to the schema soft freeze (berkeley-schema-fy24) #217

Merged
merged 101 commits into from
Jul 3, 2024

Conversation

mslarae13
Copy link
Collaborator

@mslarae13 mslarae13 commented Jun 26, 2024

trial and error, so many commits.

See branch to preview the PR template: https://github.com/microbiomedata/berkeley-schema-fy24/blob/1995-add-pr-template_berk_schema/.github/PULL_REQUEST_TEMPLATE/pull_request_template_berk.md

Add comments to the .md file.
the .yml file won't work for PRs

this isn't working
@turbomam
Copy link
Member

turbomam commented Jul 3, 2024

@eecavanna do you think it will be hard to coordinate with #221

@mslarae13 I added this PR against your PR so you could see the differences

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest auto-reformatting these Markdown source files. You can do that in PyCharm on Mac with command-option-L

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore me

Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
@mslarae13 mslarae13 requested a review from eecavanna July 3, 2024 22:53
@mslarae13
Copy link
Collaborator Author

Can someone review so I can merge? :) @eecavanna @turbomam

@eecavanna
Copy link

eecavanna commented Jul 3, 2024

Hi @mslarae13, this looks good to me. I have 3 suggestions. If those get "accepted", I'll approve and merge (or you can merge at that point).

@eecavanna
Copy link

And I haven't been reviewing the YAML file (I don't know what its role is, given that GitHub doesn't support using a YAML file as a PR template—whereas it does for an Issue template).

mslarae13 and others added 3 commits July 3, 2024 16:09
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
@mslarae13 mslarae13 requested a review from eecavanna July 3, 2024 23:10
Copy link

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown file (i.e. PR template) looks good to me! Thanks for tackling this, @mslarae13.


Note: I did not review the YAML file as I don't know what its role is (given that GitHub doesn't support using a YAML file as a PR template).

@eecavanna eecavanna changed the title 1995 add pr template for berkeley-schema-fy24 Add PR template specific to the schema soft freeze (berkeley-schema-fy24) Jul 3, 2024
@eecavanna
Copy link

eecavanna commented Jul 3, 2024

I deleted the YAML file as @mslarae13 and I discussed on Slack just now.

I updated the PR title in preparation for it appearing in the repo's release notes.

I'm comfortable with this PR branch being merged into the main branch.

@mslarae13
Copy link
Collaborator Author

merging. Any additional changes should be suggested via another branch & PR.

@eecavanna is going to add/update the branch & PR for nmdc-schema

@mslarae13 mslarae13 merged commit f4d2b4c into main Jul 3, 2024
3 checks passed
@mslarae13 mslarae13 deleted the 1995-add-pr-template_berk_schema branch July 3, 2024 23:22
@eecavanna
Copy link

I finished updating the PR in nmdc-schema (i.e. this one: microbiomedata#2105) to have the same PR template as the final one introduced by this PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add PR template
3 participants