-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR template specific to the schema soft freeze (berkeley-schema-fy24
)
#217
Conversation
create PR temp file
testing yaml
try again?
this isn't working
@eecavanna do you think it will be hard to coordinate with #221 @mslarae13 I added this PR against your PR so you could see the differences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest auto-reformatting these Markdown source files. You can do that in PyCharm on Mac with command-option-L
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore me
mam pr template suggestions v1
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Can someone review so I can merge? :) @eecavanna @turbomam |
Hi @mslarae13, this looks good to me. I have 3 suggestions. If those get "accepted", I'll approve and merge (or you can merge at that point). |
And I haven't been reviewing the YAML file (I don't know what its role is, given that GitHub doesn't support using a YAML file as a PR template—whereas it does for an Issue template). |
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Markdown file (i.e. PR template) looks good to me! Thanks for tackling this, @mslarae13.
Note: I did not review the YAML file as I don't know what its role is (given that GitHub doesn't support using a YAML file as a PR template).
berkeley-schema-fy24
berkeley-schema-fy24
)
I deleted the YAML file as @mslarae13 and I discussed on Slack just now. I updated the PR title in preparation for it appearing in the repo's release notes. I'm comfortable with this PR branch being merged into the |
merging. Any additional changes should be suggested via another branch & PR. @eecavanna is going to add/update the branch & PR for nmdc-schema |
I finished updating the PR in |
trial and error, so many commits.
See branch to preview the PR template: https://github.com/microbiomedata/berkeley-schema-fy24/blob/1995-add-pr-template_berk_schema/.github/PULL_REQUEST_TEMPLATE/pull_request_template_berk.md
Add comments to the .md file.
the .yml file won't work for PRs