Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove was_informed_by from WorkflowExecution and update data examples #30

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove was_informed_by from WorkflowExecution and update data examples #30

merged 1 commit into from
Dec 14, 2023

Conversation

mbthornton-lbl
Copy link
Collaborator

This PR provides:

  • removal of was_informed_by slot from WorkflowExecution
  • update to valid data examples
  • add invalid data example
  • delete .json file from data/valid

@turbomam turbomam merged commit 19717aa into main Dec 14, 2023
2 checks passed
@turbomam turbomam deleted the 1537_remove_was_informed_by_from_WorkflowExecution branch December 14, 2023 21:43
@brynnz22 brynnz22 added the migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. label Dec 22, 2023
@brynnz22
Copy link
Collaborator

migration impacts all WorkflowExecution(Activity) sets that use was_informed_by. was_informed_by slot and value will move to new WorkflowChain class. For migration

@brynnz22
Copy link
Collaborator

brynnz22 commented Jan 5, 2024

Can not remove this until WorkflowChain is created. See @aclum's comment in microbiomedata#1537 (comment)

@brynnz22 brynnz22 added the migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration label Jan 6, 2024
@brynnz22 brynnz22 changed the title Remove was_informed_by from WorkflowExecution and update data examples Remove was_informed_by from WorkflowExecution and update data examples Apr 19, 2024
@brynnz22 brynnz22 added the migrator-written a migrator script has been written addressing the PR/schema change label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbomam turbomam turbomam approved these changes

@brynnz22 brynnz22 Awaiting requested review from brynnz22

@anastasiyaprymolenna anastasiyaprymolenna Awaiting requested review from anastasiyaprymolenna

Assignees
No one assigned
Labels
migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration migrator-written a migrator script has been written addressing the PR/schema change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbthornton-lbl @brynnz22 @turbomam