add slots to MaterialProcessing classes that were on omics processing
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aclum extraction_method slot on Class:Extraction needs to reviewed. We should get rid of it if it is not being used because the enum it is using is shared with extraction_target so it is not informative. |
|
All wrong try again |
|
@anastasiyaprymolenna see example data https://github.com/microbiomedata/nmdc-schema/blob/main/src/data/valid/Database-nucleic-extraction.yaml |
…-that-were-on-OmicsProcessing
aclum
approved these changes
Dec 13, 2023
mslarae13
deleted the
1525-add-slots-to-MaterialProcessing-classes-that-were-on-OmicsProcessing
branch
|
no migration |
brynnz22
changed the title
MaterialProcessing classes that were on omics processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nucl_acid_ext exists on OmicsProcessing (DataGeneration) and Biosample
This PR is adding MIXS slot nucl_acid_ext as a narrow_mapping for extraction_method and extraction_target as it's providing BOTH
This PR also adds http://purl.obolibrary.org/obo/NCIT_C177560 as a narrow_mapping for both extraction_method and extraction_target as this is also a more specific way of identifying BOTH.