-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add permissible values to InstrumentVendorEnum
and InstrumentModelEnum
for sequencing applications
#70
Conversation
Adding to InstrumentVendorEnum and InstrumentModelEnum for sequencing applications.
fix typo.
changing to a valid model
updating to a valid permissible value for model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent enumeration PR. Thanks for the thorough annotation with OBI terms. Was it a pain to pick them all out? @cmungall and I have some ideas for providing some automation.
If there's one single exact_mapping for a permissible value, it would be better to express it as the meaning
of the PV. mappings
are textual annotations but meaning
s are structural. If the schema or the data are converted to RDF, the meaning
s can be queried for subclasses, superclasses, and other grouping axioms.
If that's OK with you, it could be quickly accomplished with
s/exact_mappings:\n +- /meaning: /
Update exact_mappings to meaning for InstrumentVendorEnum and InstrumentModelEnum, add revio as permissible value for InstrumentModelEnum.
@turbomam This was a bit painful b/c you can't see the actual term IDs in the tree view. Probably would have been better to dump this and use some of the ontology tools but I'm not very familiar with those. It would be useful to have a little script that could make a permissible value out of every child of a term (in this case a good starting point would have been to make a term for all the children of OBI:0400103, then delete the ones we don't need). |
Add prefix for BAO
Switching back to an OBI for illumina permissible value meaning
InstrumentVendorEnum
and InstrumentModelEnum
for sequencing applications
This PR expands on the two enumerations to support sequencing based vendors and models.
We will need to write migration code to map existing values of
instrument_name
tovendor
andmodel
.